Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wifi370 error messages #36

Open
mwittig opened this issue Dec 22, 2015 · 3 comments
Open

Wifi370 error messages #36

mwittig opened this issue Dec 22, 2015 · 3 comments

Comments

@mwittig
Copy link
Collaborator

mwittig commented Dec 22, 2015

pimatic-led-light is producing lots of errors for me:
error [pimatic-led-light]: [Error: write after end]
and
error [pimatic-led-light]: [Error: connection timeout]

See also #27

@philip1986
Copy link
Owner

Maybe connection handling in the "driver" needs to be refactored. Currently it establishes a new connection for each call. Might be better to go with a singleton pattern and reuse one connection.

@mwittig
Copy link
Collaborator Author

mwittig commented Dec 22, 2015

Agree, but synchronizing to a single connection can be tricky as it may introduce hidden "race conditions" caused depending on the ordering of events processed. I had to implement a single connection handling as part of pimatic-denon-avr as the AVR only accepts a single connection.

@philip1986
Copy link
Owner

@mwittig yeah that is true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants