Skip to content

Commit 924c7e6

Browse files
Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (flutter#6416)" (flutter#6419)
Reverts: flutter/packages#6416 Initiated by: ditman Reason for reverting: Failures happen (later) in other plugins (more updates in the related issue) flutter#145866 Original PR Author: ditman Reviewed By: {jmagman} This change reverts the following previous change: Adds `--allow-warnings` to podspec_check_command.dart so stuff can keep rolling. **To be removed soon!**
1 parent e234425 commit 924c7e6

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

script/tool/lib/src/podspec_check_command.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ class PodspecCheckCommand extends PackageLoopingCommand {
151151
podspecPath,
152152
'--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices.
153153
'--skip-tests',
154-
'--allow-warnings',
155154
'--use-modular-headers', // Flutter sets use_modular_headers! in its templates.
156155
if (libraryLint) '--use-libraries'
157156
];

script/tool/test/podspec_check_command_test.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@ void main() {
156156
.path,
157157
'--configuration=Debug',
158158
'--skip-tests',
159-
'--allow-warnings',
160159
'--use-modular-headers',
161160
'--use-libraries'
162161
],
@@ -172,7 +171,6 @@ void main() {
172171
.path,
173172
'--configuration=Debug',
174173
'--skip-tests',
175-
'--allow-warnings',
176174
'--use-modular-headers',
177175
],
178176
packagesDir.path),
@@ -214,7 +212,6 @@ void main() {
214212
.path,
215213
'--configuration=Debug',
216214
'--skip-tests',
217-
'--allow-warnings',
218215
'--use-modular-headers',
219216
'--use-libraries'
220217
],
@@ -230,7 +227,6 @@ void main() {
230227
.path,
231228
'--configuration=Debug',
232229
'--skip-tests',
233-
'--allow-warnings',
234230
'--use-modular-headers',
235231
],
236232
packagesDir.path),

0 commit comments

Comments
 (0)