Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all non-menu-defined shortcuts appropriately #7353

Open
sardination opened this issue Aug 26, 2022 · 0 comments
Open

Handle all non-menu-defined shortcuts appropriately #7353

sardination opened this issue Aug 26, 2022 · 0 comments
Labels
feature New feature or request long-term/tech-debt Issues that are extremely low priority 📁 Repo: hybrid This PR/Issue modifies /hybrid code 📁 Repo: mandelboxes This PR/Issue modifies /mandelboxes code

Comments

@sardination
Copy link
Contributor

Bug Description
So far, this has only been a problem for zooming in. The menu shortcut for zooming in is CMD +, but the non-menu-defined shortcut CMD = also works. For some reason, Chromium handles menu-defined and non-menu-defined shortcuts differently. To get around this for zooming in, we implemented the changes seen here: https://github.com/whisthq/brave-core/pull/518.

How to Reproduce
Try a non-menu defined shortcut that should be handled client-side and see how it actually gets handled server-side instead.

Potential Implementation(s)
Figure out what pathway these non-menu-defined shortcuts take and have a universal handler for them that makes sure that the appropriate shortcuts are handled server and client-side.

@sardination sardination added the long-term/tech-debt Issues that are extremely low priority label Aug 26, 2022
@philippemnoel philippemnoel added the feature New feature or request label Aug 30, 2022
@philippemnoel philippemnoel transferred this issue from another repository Sep 22, 2022
@philippemnoel philippemnoel added 📁 Repo: mandelboxes This PR/Issue modifies /mandelboxes code 📁 Repo: hybrid This PR/Issue modifies /hybrid code labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request long-term/tech-debt Issues that are extremely low priority 📁 Repo: hybrid This PR/Issue modifies /hybrid code 📁 Repo: mandelboxes This PR/Issue modifies /mandelboxes code
Projects
None yet
Development

No branches or pull requests

2 participants