Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist bucket has no SSE configuration #1320

Closed
marekaf opened this issue Oct 21, 2021 · 2 comments
Closed

dist bucket has no SSE configuration #1320

marekaf opened this issue Oct 21, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@marekaf
Copy link
Contributor

marekaf commented Oct 21, 2021

Hi, would it be possible to add optional SSE configuration to all the s3 bucket resources?

terraform-aws-github-runner/modules/runner-binaries-syncer/main.tf

Line 5 in 65aab80

resource "aws_s3_bucket" "action_dist" {

I'l be happy to implement it.
@npalm
Copy link
Member

npalm commented Oct 21, 2021

Yes feel free to create a PR! Since I added the bucket and data only for caching a public copy I never spend time on SSE. But feel free to add SSE support as an option to the module

@npalm npalm added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 21, 2021
@marekaf marekaf mentioned this issue Oct 22, 2021
Merged
@gautamkrishnar
Copy link

@npalm this can be closed right

@npalm npalm closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gautamkrishnar @npalm @marekaf