Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No explicit block is causing errors #2017

Closed
gusfune opened this issue May 5, 2022 · 3 comments · Fixed by #2019
Closed

No explicit block is causing errors #2017

gusfune opened this issue May 5, 2022 · 3 comments · Fixed by #2019

Comments

@gusfune
Copy link
Contributor

gusfune commented May 5, 2022

After the release of 0.40.3 I have noticed that the runners were not triggering when having no block_device_mapping set in the terraform file.

The error show in AWS was:

ErrorMessage: 'Invalid device name /dev/xvd'

After some digging the issue found was that this block:

default = [{
    device_name           = "/dev/xvd"
    delete_on_termination = true
    volume_type           = "gp3"
    volume_size           = 30
    encrypted             = true
    iops                  = null
  }]

Actually should be

default = [{
    device_name           = "/dev/xvda"
    delete_on_termination = true
    volume_type           = "gp3"
    volume_size           = 30
    encrypted             = true
    iops                  = null
  }]

I managed to fix my main.tf file by setting this block below:

block_device_mappings = [{
    device_name           = "/dev/xvda"
    delete_on_termination = true
    volume_type           = "gp3"
    volume_size           = 30
    encrypted             = true
    iops                  = null
  }]
``

But, the default configuration should be reviewed. This was caused by #2014 to fix the issue I have reported on #1954.
@npalm
Copy link
Member

npalm commented May 5, 2022

Thx! Just find the same issue.

@gusfune
Copy link
Contributor Author

gusfune commented May 5, 2022

I have already pushed a fix for this @npalm on #2018 if that helps.

@npalm
Copy link
Member

npalm commented May 5, 2022

@gusfune thx, tested and one file was missed for the fix. Provided another fix on top of yours. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants