Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition #2614

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

jokreliable
Copy link
Contributor

The role policy needs to use the variable so that when deployed into govcloud (or other non-default partition setup) the referenced parameter can be created and/or found.

@jokreliable jokreliable changed the title quick fix: use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition fix: use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition Nov 3, 2022
@npalm npalm self-requested a review November 3, 2022 23:31
@npalm npalm changed the title fix: use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition fix: Use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition Nov 3, 2022
@npalm npalm merged commit 7ac65e5 into philips-labs:develop Nov 3, 2022
forest-releaser bot pushed a commit that referenced this pull request Nov 8, 2022
## [1.15.0](v1.14.0...v1.15.0) (2022-11-08)

### Features

* Allow to toggle access to EC2 instance tags ([#2592](#2592)) ([55fba22](55fba22))

### Bug Fixes

* Use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition ([#2614](#2614)) ([7ac65e5](7ac65e5))
npalm pushed a commit that referenced this pull request Nov 17, 2022
## [1.15.0](v1.14.0...v1.15.0) (2022-11-08)

### Features

* Allow to toggle access to EC2 instance tags ([#2592](#2592)) ([55fba22](55fba22))

### Bug Fixes

* Use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition ([#2614](#2614)) ([7ac65e5](7ac65e5))
npalm pushed a commit that referenced this pull request Dec 13, 2022
## [1.15.0](v1.14.0...v1.15.0) (2022-11-08)

### Features

* Allow to toggle access to EC2 instance tags ([#2592](#2592)) ([55fba22](55fba22))

### Bug Fixes

* Use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition ([#2614](#2614)) ([7ac65e5](7ac65e5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants