Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): Adds InsufficientInstanceCapacity to list of scaling errors #2926

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

tcsc
Copy link
Contributor

@tcsc tcsc commented Feb 6, 2023

The ScaleUp lambda is dropping events when there is no capacity in the zone. This results in jobs being stalled and requiring manual cancellation.

This patch adds the InsufficientInstanceCapacity error code to the list of scale-up errors, allowing the built-in retry mechanism to pick up the error and not lose the event

See-Also: #2925

@tcsc tcsc changed the title Adds InsufficientInstanceCapacity to list of scaling errors fix: Adds InsufficientInstanceCapacity to list of scaling errors Feb 6, 2023
@tcsc tcsc force-pushed the tcsc/add-InsufficientInstanceCapacity branch from 47a4634 to 5b8a531 Compare February 6, 2023 02:01
@npalm npalm changed the title fix: Adds InsufficientInstanceCapacity to list of scaling errors fix(runner): Adds InsufficientInstanceCapacity to list of scaling errors Feb 10, 2023
@npalm
Copy link
Member

npalm commented Feb 10, 2023

fix #2925

@npalm npalm merged commit 4eb3b16 into philips-labs:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants