Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow lambda inside VPC #2938

Merged
merged 14 commits into from
Feb 17, 2023

Conversation

jsalcedo1987
Copy link
Contributor

Hi! 👋

This PR contains the following changes:

  • It allows webhook lambda to run inside a VPC
  • fix a minor issue in the syncer module, when the lambda is running inside vpc AWSLambdaVPCAccessExecutionRole needs to be attached.

Updated doc.

Do not hesitate to ask if you need further details,
Thanks!

@jsalcedo1987 jsalcedo1987 changed the title Allow lambda inside VPC fix: Allow lambda inside VPC Feb 9, 2023
@npalm npalm self-requested a review February 10, 2023 13:04
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsalcedo1987 Thanks for your contribution. A small remark. We basides the top level main module also the variables needs to be added to the mult-runner module.

main.tf Show resolved Hide resolved
@jsalcedo1987 jsalcedo1987 requested a review from npalm February 10, 2023 16:25
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsalcedo1987 thanks looks all good now

@npalm npalm merged commit 4bb80be into philips-labs:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants