fix(runners): Fix typo in .setup_info generated in start-runner.ps1. #2967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small typo in
start-runner.ps1
, this time making the AMI id fail to appear in the "Set up job" section of the workflow log.See the bash version of the same script, which doesn't have the typo:
terraform-aws-github-runner/modules/runners/templates/start-runner.sh
Line 82 in ef548d9
And also the GitHub Actions Runner docs, where it says it's
detail
notdetails
:https://github.com/actions/runner/blob/main/docs/adrs/0354-runner-machine-info.md
By the way, I've also modified this section of the code in our local fork to include the EC2 instance type along the the AMI ID, which is very useful because our jobs are allowed to run on a long list of different instance types. It looks like this:
Note the new "Instance Type" field. Let me know if you would like a PR for that change as well.