Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runners): Fix typo in .setup_info generated in start-runner.ps1. #2967

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

kring
Copy link
Contributor

@kring kring commented Feb 20, 2023

Another small typo in start-runner.ps1, this time making the AMI id fail to appear in the "Set up job" section of the workflow log.

See the bash version of the same script, which doesn't have the typo:

And also the GitHub Actions Runner docs, where it says it's detail not details:
https://github.com/actions/runner/blob/main/docs/adrs/0354-runner-machine-info.md

By the way, I've also modified this section of the code in our local fork to include the EC2 instance type along the the AMI ID, which is very useful because our jobs are allowed to run on a long list of different instance types. It looks like this:

image

Note the new "Instance Type" field. Let me know if you would like a PR for that change as well.

@npalm npalm self-requested a review February 21, 2023 20:28
@npalm npalm merged commit e8f74bc into philips-labs:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants