Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing propagation of runner_ec2_tags to EC2 volumes #2984

Closed
v-rosa opened this issue Feb 22, 2023 · 0 comments
Closed

missing propagation of runner_ec2_tags to EC2 volumes #2984

v-rosa opened this issue Feb 22, 2023 · 0 comments

Comments

@v-rosa
Copy link
Contributor

v-rosa commented Feb 22, 2023 •
edited
Loading

Current implementation is missing the propagation of var.runner_ec2_tags into EC2 volumes.

https://github.com/philips-labs/terraform-aws-github-runner/blob/main/modules/runners/main.tf#L128-L136

We could use local.tags but it might be problematic if the AWS provider is using the default_tags due to the documented perpetual drift: https://support.hashicorp.com/hc/en-us/articles/4406026108435-Known-issues-with-default-tags-in-the-Terraform-AWS-Provider

#2985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@npalm @v-rosa