Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runners): upgrade aws sdk v2 to v3 #3138

Merged
merged 5 commits into from
Apr 7, 2023
Merged

fix(runners): upgrade aws sdk v2 to v3 #3138

merged 5 commits into from
Apr 7, 2023

Conversation

npalm
Copy link
Member

@npalm npalm commented Mar 30, 2023 •
edited
Loading

Updates the AWS sdk for the runners lambda's from v2 to v3

Tasks:

  • - update code
  • - run test with actual deployed runners

Notes

  • Refactored types, moved types for runners to a separate file
  • Tests, mocks replaces, test should be unchanged

@npalm npalm marked this pull request as draft March 30, 2023 22:07
@npalm npalm force-pushed the fix/upgrade-runner-lambda-aws-sdk branch from 9336913 to 73332d4 Compare April 1, 2023 12:48
@npalm npalm marked this pull request as ready for review April 1, 2023 12:53
@npalm npalm marked this pull request as draft April 1, 2023 12:55
@npalm npalm marked this pull request as ready for review April 1, 2023 12:57
@npalm npalm force-pushed the fix/upgrade-runner-lambda-aws-sdk branch from 161cdbb to aa8af02 Compare April 1, 2023 21:48
@npalm npalm requested a review from ScottGuymer April 7, 2023 11:39
@npalm npalm merged commit 48da039 into main Apr 7, 2023
@npalm npalm deleted the fix/upgrade-runner-lambda-aws-sdk branch April 7, 2023 15:08
@forest-releaser forest-releaser bot mentioned this pull request Apr 7, 2023
Merged
@forest-releaser forest-releaser bot mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottGuymer ScottGuymer ScottGuymer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npalm @ScottGuymer @GuptaNavdeep1983