-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): Add support for X-Ray tracing #3142
Conversation
@npalm Not sure what is up with the tfdocs workflow |
I recently move the update of the tfdocs to the release branch. But this conflicts with the pre-commit hook with tfdocs. So therefore I removed the pre-commit. And run the workflow on the PR. But that seems not working. Will dig in next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will check in detail later. But it seems you missed the pool lambda, which is in as submodule of the runners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcaulifn thx, I ran a quick test and only see tracing for the scale-down, not for the scale-up. Need to dig in a bit more next wee.
Besides that can you also add the tracing variable to multi-runner module.
Added to multi- and pool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and got a working with some tweaks:
- multi-runner module file runner-binaries.tf add
lambda_tracing_mode = var.lambda_tracing_mode
- multi-runner module file webhook.tf add
lambda_tracing_mode = var.lambda_tracing_mode
- missed a policy for the pool see inlince comment.
changes also available on branch https://github.com/philips-labs/terraform-aws-github-runner/tree/mcaulifn/xray
@mcaulifn just pushed my addition to your branch |
Add support for x-ray