Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runners): allow explicitly standard or unlimited #3244

Merged
merged 8 commits into from
May 12, 2023

Conversation

alexjurkiewicz
Copy link
Contributor

Allow configuring T instance types as explicitly standard or unlimited
credit model.

This can help to control costs when using T instances as a "cpu-limited"
runner pool.

@GuptaNavdeep1983 GuptaNavdeep1983 requested a review from npalm May 2, 2023 16:00
@alexjurkiewicz alexjurkiewicz force-pushed the credit-specification branch from e6c3d2a to 970030c Compare May 3, 2023 03:15
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good in general, one change request. The runners can be created from the root and the submodule multi-runners

modules/runners/variables.tf Show resolved Hide resolved
alexjurkiewicz and others added 7 commits May 9, 2023 17:26
Allow configuring T instance types as explicitly standard or unlimited
credit model.

This can help to control costs when using T instances as a "cpu-limited"
runner pool.
Also use it in the multi-runner example, as a test.
@alexjurkiewicz alexjurkiewicz force-pushed the credit-specification branch from b75bdc0 to 426f5e6 Compare May 9, 2023 09:26
@GuptaNavdeep1983
Copy link
Contributor

Tested the changes and they look good. Thanks.

@npalm npalm changed the title feat: Add var.runner_credit_specification feat: allow explicitly standard or unlimited May 11, 2023
@npalm npalm changed the title feat: allow explicitly standard or unlimited feat(runners): allow explicitly standard or unlimited May 12, 2023
@npalm npalm merged commit e2cf7ac into philips-labs:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants