-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runners): allow explicitly standard or unlimited #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjurkiewicz
force-pushed
the
credit-specification
branch
from
May 3, 2023 03:15
e6c3d2a
to
970030c
Compare
GuptaNavdeep1983
previously approved these changes
May 3, 2023
npalm
requested changes
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks good in general, one change request. The runners can be created from the root and the submodule multi-runners
Allow configuring T instance types as explicitly standard or unlimited credit model. This can help to control costs when using T instances as a "cpu-limited" runner pool.
Also use it in the multi-runner example, as a test.
alexjurkiewicz
force-pushed
the
credit-specification
branch
from
May 9, 2023 09:26
b75bdc0
to
426f5e6
Compare
GuptaNavdeep1983
approved these changes
May 10, 2023
Tested the changes and they look good. Thanks. |
npalm
approved these changes
May 11, 2023
npalm
changed the title
feat: Add var.runner_credit_specification
feat: allow explicitly standard or unlimited
May 11, 2023
npalm
changed the title
feat: allow explicitly standard or unlimited
feat(runners): allow explicitly standard or unlimited
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring T instance types as explicitly standard or unlimited
credit model.
This can help to control costs when using T instances as a "cpu-limited"
runner pool.