fix!: Change runner labels to list[string] and apply TFLint #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determine extra-labels based on label matchers
5 tasks
|
@koendelaat I have revived your PR in a dedicated branch, added you as contributor as well. Once ready will merge the PR in a branch next. I plannign also to do some major refactoring on variables. |
|
@koendelaat can make a comment what your idea was about naming conventions for objects? |
|
@npalm some objects are used in submodules in Terraform, other are directly passthrough to software components. The latter need to follow the coding style of that component. For the first one I would suggest using codestyle of Terraform. Points to consider:
|
@koendelaat I have addressed the issues in a dedicated issue #3411 Any thoughts on this issue? |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
npalm
changed the title
|
Ready and tested |
npalm
added a commit
that referenced
this pull request
Oct 26, 2023
Change variables `runner_labels` and `runner_extra_labels` to type: `list[string]` to better represent the content Additionally: - [x] Automatic determine runner labels for multi runner based on label matchers - [x] Enable Terraform linting on all modules, including naming conventions - [x] Enable check annotations for linting errors - [x] Fix existing linting errors - [ ] Apply naming conventions within objects (not supported by [TFLint](terraform-linters/tflint#1310)) This PR is based on #3143 creaed by @koendelaat but now via a dedicate branch in this repository. --------- Co-authored-by: Koen de Laat <koen.de.laat@philips.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
npalm
added a commit
that referenced
this pull request
Oct 27, 2023
Change variables `runner_labels` and `runner_extra_labels` to type: `list[string]` to better represent the content Additionally: - [x] Automatic determine runner labels for multi runner based on label matchers - [x] Enable Terraform linting on all modules, including naming conventions - [x] Enable check annotations for linting errors - [x] Fix existing linting errors - [ ] Apply naming conventions within objects (not supported by [TFLint](terraform-linters/tflint#1310)) This PR is based on #3143 creaed by @koendelaat but now via a dedicate branch in this repository. --------- Co-authored-by: Koen de Laat <koen.de.laat@philips.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
npalm
pushed a commit
that referenced
this pull request
Oct 27, 2023
🤖 I have created a release *beep* *boop* --- ## [5.0.0](v4.7.0...v5.0.0) (2023-10-27) ### Migration directions See [PR](#3552) for migration directions. ### ⚠ BREAKING CHANGES * remove depcrecated input and output variables ([#3567](#3567)) * Change runner labels to list[string] and apply TFLint ([#3410](#3410)) * replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI ([#3437](#3437)) ### Features * replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI ([#3437](#3437)) ([35219f5](35219f5)) ### Bug Fixes * Change runner labels to list[string] and apply TFLint ([#3410](#3410)) ([0b398f2](0b398f2)) * remove depcrecated input and output variables ([#3567](#3567)) ([89c8575](89c8575)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change variables
runner_labelsandrunner_extra_labelsto type:list[string]to better represent the contentAdditionally:
This PR is based on #3143 creaed by @koendelaat but now via a dedicate branch in this repository.