feat!: replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI #3437

eabrouwer3 · 2023-08-16T19:31:22Z

Add runner_amazon_linux_2022 boolean variable

Get rid of amazon linux 2022 config option

Make PR changes even smaller

Update all references to amzn2. Also bump to al2023 (latest supported version)

Add the al2023 packer file

eabrouwer3 · 2023-08-16T19:31:43Z

Working right now on addressing the latest comment from #3293.

Add `runner_amazon_linux_2022` boolean variable Get rid of amazon linux 2022 config option Make PR changes even smaller Update all references to amzn2. Also bump to al2023 (latest supported version) Add the al2023 packer file curl comes shipped with al2023

eabrouwer3 · 2023-08-16T20:40:03Z

@GuptaNavdeep1983, I've fixed the packer build issue and rebased master onto my branch, so I think I've addressed any issues you had on the old PR.

@npalm, tagging you on this as well, as you were the "reviewer" on the old PR.

modules/runners/templates/install-runner.sh

modules/runners/main.tf

Chobito · 2023-09-13T10:27:59Z

any update on this? seems that packer check failed due rate limit

…orm-aws-github-runner into eb/2848-al2023-support

eabrouwer3 · 2023-09-13T16:07:15Z

I've pushed up a change that resolves the two PR comments. Thanks @wangzw!

npalm

Just checked the PR with mult-runner example. Both the arm64 and amazon linux runners are not coming online. On the x64 runner looks like the curl installation is failing.

wangzw · 2023-09-15T07:44:41Z

Just checked the PR with mult-runner example. Both the arm64 and amazon linux runners are not coming online. On the x64 runner looks like the curl installation is failing.

You are right, curl-minimal is installed by default, and conflict with curl, I forget to mention that.

@eabrouwer3

eabrouwer3 · 2023-09-18T20:18:01Z

Just checked the PR with mult-runner example. Both the arm64 and amazon linux runners are not coming online. On the x64 runner looks like the curl installation is failing.

You are right, curl-minimal is installed by default, and conflict with curl, I forget to mention that.

So should we remove the curl install then? In modules/runners/templates/user-data.sh. I think we still need it in the ubuntu files where we install it, cause this shouldn't affect any of those.

wangzw · 2023-09-19T02:51:56Z

Just checked the PR with mult-runner example. Both the arm64 and amazon linux runners are not coming online. On the x64 runner looks like the curl installation is failing.

You are right, curl-minimal is installed by default, and conflict with curl, I forget to mention that.

So should we remove the curl install then? In modules/runners/templates/user-data.sh. I think we still need it in the ubuntu files where we install it, cause this shouldn't affect any of those.

I do not think yum install -y curl works for ubuntu, so just remove it. Anyone who use ubuntu has to customized a user_data.sh

Default user_data.sh only needs to match your default image.

wangzw · 2023-09-23T03:54:35Z

Looks good to me, but you need to fix the conflicts.

aktur · 2023-09-24T11:53:53Z

@eabrouwer3 I was updating a runner to Linux 2023 recently too and have two comments:

you should use dnf instead of yum on Linux 2023;
to install curl without conflicts, use the following line dnf install curl -y --allowerasing.

npalm · 2023-10-05T06:24:48Z

Will test the PR asap. Would like to get the PR merged with other breaking changes planned.

modules/runners/templates/install-runner.sh

npalm

Validatinging examples

default
multi runners
pre-build ami

Mogost · 2023-10-10T10:37:16Z

Looks like this is connected to #3534

aktur · 2023-10-10T10:42:43Z

Looks like this is connected to #3534

Yes, it is. I successfully ran the PR's runner, and the error has been resolved.

garethallen-daemon · 2023-10-13T07:13:13Z

Any update on this?

npalm

Tested an all good. I will merge the PR into next. We planning to combine a few breaking changes and release next week.

…MI (#3437) Replaces Amazon lLnux 2 (default) by Amazon Linux 2023. Impact for anyone relying on the default setup provided by the module. --------- Co-authored-by: Niek Palm <npalm@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [5.0.0](v4.7.0...v5.0.0) (2023-10-27) ### Migration directions See [PR](#3552) for migration directions. ### ⚠ BREAKING CHANGES * remove depcrecated input and output variables ([#3567](#3567)) * Change runner labels to list[string] and apply TFLint ([#3410](#3410)) * replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI ([#3437](#3437)) ### Features * replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI ([#3437](#3437)) ([35219f5](35219f5)) ### Bug Fixes * Change runner labels to list[string] and apply TFLint ([#3410](#3410)) ([0b398f2](0b398f2)) * remove depcrecated input and output variables ([#3567](#3567)) ([89c8575](89c8575)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>

eabrouwer3 force-pushed the eb/2848-al2023-support branch from 080e2d0 to affea44 Compare August 16, 2023 20:37

eabrouwer3 mentioned this pull request Aug 16, 2023

Support Amazon Linux 2022 AMI #2848

Closed

npalm self-requested a review August 17, 2023 20:05

npalm changed the title ~~feat: Add Support for Amazon Linux 2022~~ feat!: replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI Aug 17, 2023

eabrouwer3 added 4 commits August 22, 2023 10:59

Merge branch 'main' into eb/2848-al2023-support

39cf668

Merge branch 'main' into eb/2848-al2023-support

8aa937f

Merge branch 'main' into eb/2848-al2023-support

7c47824

Merge branch 'main' into eb/2848-al2023-support

6a1bed9

wangzw reviewed Sep 6, 2023

View reviewed changes

modules/runners/templates/install-runner.sh Outdated Show resolved Hide resolved

wangzw reviewed Sep 6, 2023

View reviewed changes

modules/runners/main.tf Outdated Show resolved Hide resolved

eabrouwer3 added 3 commits September 13, 2023 10:05

Resolve PR comments

6f0769c

Merge branch 'eb/2848-al2023-support' of github.com:eabrouwer3/terraf…

f3fea6d

…orm-aws-github-runner into eb/2848-al2023-support

Merge branch 'main' into eb/2848-al2023-support

091cbed

npalm reviewed Sep 14, 2023

View reviewed changes

ay0o mentioned this pull request Sep 18, 2023

Amazon Linux 2023 runners are not registering with GitHub #3263

Closed

eabrouwer3 added 2 commits September 19, 2023 09:40

Remove curl install

9565428

Merge branch 'main' into eb/2848-al2023-support

c5304f7

npalm self-requested a review September 19, 2023 20:09

Merge branch 'main' into eb/2848-al2023-support

cb72839

Merge branch 'main' into eb/2848-al2023-support

8d9971e

Merge branch 'main' into eb/2848-al2023-support

233d430

npalm reviewed Oct 5, 2023

View reviewed changes

modules/runners/templates/install-runner.sh Show resolved Hide resolved

npalm reviewed Oct 6, 2023

View reviewed changes

aktur approved these changes Oct 6, 2023

View reviewed changes

matthowardcohere approved these changes Oct 9, 2023

View reviewed changes

Mogost approved these changes Oct 10, 2023

View reviewed changes

ivan-klass approved these changes Oct 10, 2023

View reviewed changes

swibrow mentioned this pull request Oct 10, 2023

Add amazon linux 2023 tx-pts-dai/terraform-aws-ec2-actions-runners#15

Merged

olyhuta approved these changes Oct 10, 2023

View reviewed changes

Swadhin-K mentioned this pull request Oct 10, 2023

Github action runners can't execute jobs #3534

Closed

devdavidkarlsson approved these changes Oct 10, 2023

View reviewed changes

Chobito approved these changes Oct 10, 2023

View reviewed changes

npalm added 2 commits October 14, 2023 10:49

Merge branch 'main' into eb/2848-al2023-support

ab8a992

Merge branch 'main' into eb/2848-al2023-support

865da76

npalm changed the base branch from main to next October 19, 2023 11:52

npalm changed the base branch from next to main October 19, 2023 11:53

npalm changed the base branch from main to next October 19, 2023 12:06

npalm approved these changes Oct 19, 2023

View reviewed changes

npalm merged commit fb0f7e3 into philips-labs:next Oct 19, 2023
28 checks passed

eabrouwer3 deleted the eb/2848-al2023-support branch October 19, 2023 17:31

This was referenced Oct 20, 2023

Release 5.0.0 #3553

Closed

chore: Next major release #3552

Merged

forest-releaser bot mentioned this pull request Oct 27, 2023

chore(main): release 5.0.0 #3571

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI #3437

feat!: replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI #3437

eabrouwer3 commented Aug 16, 2023

eabrouwer3 commented Aug 16, 2023

eabrouwer3 commented Aug 16, 2023

Chobito commented Sep 13, 2023

eabrouwer3 commented Sep 13, 2023

npalm left a comment

wangzw commented Sep 15, 2023

eabrouwer3 commented Sep 18, 2023

wangzw commented Sep 19, 2023 •

edited

Loading

wangzw commented Sep 23, 2023

aktur commented Sep 24, 2023

npalm commented Oct 5, 2023

npalm left a comment •

edited

Loading

Mogost commented Oct 10, 2023

aktur commented Oct 10, 2023 •

edited

Loading

garethallen-daemon commented Oct 13, 2023

npalm left a comment

feat!: replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI #3437

feat!: replace Amazon Linux 2 by Amazon Linux 2023 as default Linux AMI #3437

Conversation

eabrouwer3 commented Aug 16, 2023

eabrouwer3 commented Aug 16, 2023

eabrouwer3 commented Aug 16, 2023

Chobito commented Sep 13, 2023

eabrouwer3 commented Sep 13, 2023

npalm left a comment

Choose a reason for hiding this comment

wangzw commented Sep 15, 2023

eabrouwer3 commented Sep 18, 2023

wangzw commented Sep 19, 2023 • edited Loading

wangzw commented Sep 23, 2023

aktur commented Sep 24, 2023

npalm commented Oct 5, 2023

npalm left a comment • edited Loading

Choose a reason for hiding this comment

Mogost commented Oct 10, 2023

aktur commented Oct 10, 2023 • edited Loading

garethallen-daemon commented Oct 13, 2023

npalm left a comment

Choose a reason for hiding this comment

wangzw commented Sep 19, 2023 •

edited

Loading

npalm left a comment •

edited

Loading

aktur commented Oct 10, 2023 •

edited

Loading