-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for cloudwatch config on multi-runners #3447
Merged
npalm
merged 5 commits into
philips-labs:main
from
piscue:multi-runner-cloudwatch-config
Aug 24, 2023
Merged
feat: support for cloudwatch config on multi-runners #3447
npalm
merged 5 commits into
philips-labs:main
from
piscue:multi-runner-cloudwatch-config
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscue
changed the title
support for cloudwatch config on multi-runners
feat: support for cloudwatch config on multi-runners
Aug 23, 2023
piscue
force-pushed
the
multi-runner-cloudwatch-config
branch
from
August 23, 2023 10:08
6b0fe37
to
47cec54
Compare
@npalm could you take a look on this one? |
npalm
requested changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, see comment with a suggestion
npalm
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks god, wil run asap a quick test
npalm
approved these changes
Aug 24, 2023
npalm
pushed a commit
that referenced
this pull request
Aug 24, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](v4.1.2...v4.2.0) (2023-08-24) ### Features * support for cloudwatch config on per runner for multi-runners ([#3447](#3447)) ([cdaa950](cdaa950)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cloud config can only set for all multi-runners and not per runner.
Solution
Add option to set the cloud config per runner.