Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for cloudwatch config on multi-runners #3447

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

piscue
Copy link
Contributor

@piscue piscue commented Aug 23, 2023

Problem

Cloud config can only set for all multi-runners and not per runner.

Solution

Add option to set the cloud config per runner.

@piscue piscue changed the title support for cloudwatch config on multi-runners feat: support for cloudwatch config on multi-runners Aug 23, 2023
@piscue piscue force-pushed the multi-runner-cloudwatch-config branch from 6b0fe37 to 47cec54 Compare August 23, 2023 10:08
@piscue
Copy link
Contributor Author

piscue commented Aug 23, 2023

@npalm could you take a look on this one?

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see comment with a suggestion

modules/multi-runner/runners.tf Outdated Show resolved Hide resolved
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks god, wil run asap a quick test

@npalm npalm merged commit cdaa950 into philips-labs:main Aug 24, 2023
20 checks passed
npalm pushed a commit that referenced this pull request Aug 24, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](v4.1.2...v4.2.0)
(2023-08-24)


### Features

* support for cloudwatch config on per runner for multi-runners
([#3447](#3447))
([cdaa950](cdaa950))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants