Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add module to update GitHub app webhook #3451

Merged
merged 6 commits into from
Sep 25, 2023

Conversation

npalm
Copy link
Member

@npalm npalm commented Aug 24, 2023

Description

Setting up the runners are requiring typically three steps

  1. Create the GitHub App
  2. Run terraform with App details
  3. Update the GitHub App webhook.

This PR adds a module that let you update the App webhook endpoint and secret via a terraform module. Usages is sown in the examples.

@npalm npalm marked this pull request as draft August 24, 2023 13:59
@npalm npalm marked this pull request as ready for review August 24, 2023 14:07
@npalm npalm requested a review from GuptaNavdeep1983 August 24, 2023 14:07
ScottGuymer
ScottGuymer previously approved these changes Aug 24, 2023
Co-authored-by: Navdeep Gupta <navdeep.gupta@philips.com>
@npalm
Copy link
Member Author

npalm commented Aug 31, 2023

@navdeepg2021 kind reminder, can you review this one?

@Jegan-Kunniya
Copy link

@npalm - Tested the changes on Windows and all looks good. Some screenshots below

image

image

Please let me know if we need to do any additional checks.

Copy link

@Jegan-Kunniya Jegan-Kunniya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes post testing it on Windows in the Dev environment

@npalm npalm merged commit 525f400 into main Sep 25, 2023
@npalm npalm deleted the npalm/chore/example-update-webhook branch September 25, 2023 12:05
npalm pushed a commit that referenced this pull request Sep 27, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.4.0](v4.3.0...v4.4.0)
(2023-09-27)


### Features

* add module to update GitHub app webhook
([#3451](#3451))
([525f400](525f400))


### Bug Fixes

* **lambda:** bump the aws group in /lambdas with 5 updates
([#3500](#3500))
([8d4e0cd](8d4e0cd))
* **lambda:** bump the octokit group in /lambdas with 2 updates
([#3501](#3501))
([f0c1285](f0c1285))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants