-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add module to update GitHub app webhook #3451
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottGuymer
previously approved these changes
Aug 24, 2023
Co-authored-by: Navdeep Gupta <navdeep.gupta@philips.com>
@navdeepg2021 kind reminder, can you review this one? |
@npalm - Tested the changes on Windows and all looks good. Some screenshots below Please let me know if we need to do any additional checks. |
Jegan-Kunniya
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the changes post testing it on Windows in the Dev environment
ScottGuymer
approved these changes
Sep 25, 2023
npalm
pushed a commit
that referenced
this pull request
Sep 27, 2023
🤖 I have created a release *beep* *boop* --- ## [4.4.0](v4.3.0...v4.4.0) (2023-09-27) ### Features * add module to update GitHub app webhook ([#3451](#3451)) ([525f400](525f400)) ### Bug Fixes * **lambda:** bump the aws group in /lambdas with 5 updates ([#3500](#3500)) ([8d4e0cd](8d4e0cd)) * **lambda:** bump the octokit group in /lambdas with 2 updates ([#3501](#3501)) ([f0c1285](f0c1285)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting up the runners are requiring typically three steps
This PR adds a module that let you update the App webhook endpoint and secret via a terraform module. Usages is sown in the examples.