fix(webhook): Avoid jobs are accepted without labels #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuptaNavdeep1983
approved these changes
Oct 17, 2023
koendelaat
approved these changes
Oct 18, 2023
npalm
pushed a commit
that referenced
this pull request
Oct 18, 2023
🤖 I have created a release *beep* *boop* --- ## [4.5.1](v4.5.0...v4.5.1) (2023-10-18) ### Bug Fixes * **lambda:** bump the aws group in /lambdas with 5 updates ([#3530](#3530)) ([0ada33b](0ada33b)) * **webhook:** Avoid jobs are accepted without labels ([#3548](#3548)) ([cb78738](cb78738)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descirption
When using the mult-runner with an exact match set to
trueworklfows events with an empty array of labels matches the first matcher. This cause not intented runners are created. This change avoids jobs with no labels ar accepted.The exactMatch is some bagage we ccarry from the past. I have aaded a set of unit tests to show how the match is working. We should think about removing the switch.