-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Amazon linux by Ubuntu #4178
Comments
Hi, I've updated the Ubuntu example in mutli-runner to work correctly on my PR. I'd also suggest making the choice between rootless and rootful docker a configuration option, especially for ephemeral nodes (I realise this is a security risk so default to rootless). |
@bdellegrazie thanks for the work. Need some time to check the PR. I like the switch to rootless. When we created the ubuntu examples rootless was experimental. But seems not supported by docker. Wondering are you using the runners with pre built ami's. The ubuntu startime is certailny worse then Amazon linux. In our case we use an AMI solving this problem. |
@npalm rootless is supported by docker but there may be issues. In my setup I have another configuration that doesn't use rootless with purely ephemeral nodes. |
Thx, so moving by default to ubuntu has the drawback the standard setup becomes slower, which I don't like. We are not using the standard setup at all. Which create a maintenance burdan. I go to check with we can Open Source our image build setup. Which is literal a copy but simplified of the github one. |
Description
Currently we are shipping by default in the module scripts tuned for Amazon Linux and with some extra configuration Ubuntu can be used. But since GitHub is standard relying on Ubuntu several actions are not working on Amazon Linux. Or sometime updates of actions.are not fully supported out of the box.
By changing de standard configured linux version to Ubuntu we keep the module closer to the GitHub standard hosted runners. With extra configuration you can still adjust the Linux version
Once implemented this will trigger a major release.
Implementations directions
Other
Help, suggestions and feedback is welcome.
The text was updated successfully, but these errors were encountered: