Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Amazon linux by Ubuntu #4178

Open
npalm opened this issue Oct 10, 2024 · 4 comments
Open

Replace Amazon linux by Ubuntu #4178

npalm opened this issue Oct 10, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@npalm
Copy link
Member

npalm commented Oct 10, 2024

Description

Currently we are shipping by default in the module scripts tuned for Amazon Linux and with some extra configuration Ubuntu can be used. But since GitHub is standard relying on Ubuntu several actions are not working on Amazon Linux. Or sometime updates of actions.are not fully supported out of the box.

By changing de standard configured linux version to Ubuntu we keep the module closer to the GitHub standard hosted runners. With extra configuration you can still adjust the Linux version

Once implemented this will trigger a major release.

Implementations directions

  • Adjust scripts based on Ubuntu example.
  • Update the launch templates default to Ubuntu
  • Replace ubuntu example by an Amazon Linux one
  • Update multi-runner examples
  • Docs update

Other

Help, suggestions and feedback is welcome.

@npalm npalm added enhancement New feature or request help wanted Extra attention is needed labels Oct 10, 2024
@bdellegrazie
Copy link

Hi, I've updated the Ubuntu example in mutli-runner to work correctly on my PR.
That should give you a starting point.

I'd also suggest making the choice between rootless and rootful docker a configuration option, especially for ephemeral nodes (I realise this is a security risk so default to rootless).

@npalm
Copy link
Member Author

npalm commented Nov 19, 2024

@bdellegrazie thanks for the work. Need some time to check the PR. I like the switch to rootless. When we created the ubuntu examples rootless was experimental. But seems not supported by docker.

Wondering are you using the runners with pre built ami's. The ubuntu startime is certailny worse then Amazon linux. In our case we use an AMI solving this problem.

@bdellegrazie
Copy link

@npalm rootless is supported by docker but there may be issues. In my setup I have another configuration that doesn't use rootless with purely ephemeral nodes.
You're absolutely right about the start up time. Unfortunately I had to get something operational in a hurry so creating a custom AMI wasn't feasible.
However, it should be a relatively straight forward exercise, especially given the configuration is more or less exactly what is in the script currently.

@npalm
Copy link
Member Author

npalm commented Nov 20, 2024

Thx, so moving by default to ubuntu has the drawback the standard setup becomes slower, which I don't like. We are not using the standard setup at all. Which create a maintenance burdan.

I go to check with we can Open Source our image build setup. Which is literal a copy but simplified of the github one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants