Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate formatting in amp-devcontainer-cpp #582

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Sep 26, 2024

Pull Request

Description of changes

This PR delegates formatting duties for C/C++ files to the Visual Studio Clangd extension, removing the need for the separate clang-format extension.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner September 26, 2024 10:21
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:18580c6cd7f80b06ddb030a6079fdb685dbd171544ddd0e649d24b59ad655d46

OS/Platform Previous Size Current Size Delta
linux/amd64 433.13M 427.23M -5.90M (-1.36%)
linux/arm64 572.34M 566.66M -5.68M (-0.99%)

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:558aa527bdd66a4c0b7842e130d620bebd7c622503dab4858f94eaab023c4737

OS/Platform Previous Size Current Size Delta
linux/amd64 653.79M 646.29M -7.51M (-1.15%)
linux/arm64 646.22M 638.85M -7.37M (-1.14%)

Copy link
Contributor

github-actions bot commented Sep 26, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.07s
✅ DOCKERFILE hadolint 2 0 0.47s
✅ GHERKIN gherkin-lint 2 0 0.55s
✅ JSON npm-package-json-lint yes no 0.48s
✅ JSON prettier 15 2 0 0.67s
✅ JSON v8r 14 0 17.32s
✅ MARKDOWN markdownlint 8 0 0 0.98s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.21s
✅ REPOSITORY checkov yes no 18.25s
✅ REPOSITORY gitleaks yes no 0.36s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 11.74s
✅ REPOSITORY secretlint yes no 1.25s
✅ REPOSITORY syft yes no 0.53s
✅ REPOSITORY trivy yes no 7.32s
✅ REPOSITORY trivy-sbom yes no 0.89s
✅ REPOSITORY trufflehog yes no 3.45s
✅ SPELL lychee 54 0 1.09s
✅ YAML prettier 21 0 0 1.01s
✅ YAML v8r 21 0 16.4s
✅ YAML yamllint 21 0 0.5s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Test Results

 2 files  ±0   2 suites  ±0   53s ⏱️ -1s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a1ecf51. ± Comparison against base commit 9d4297e.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Sep 27, 2024

@rjaegers rjaegers added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@rjaegers rjaegers added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@rjaegers rjaegers added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit cc9380c Sep 27, 2024
19 checks passed
@rjaegers rjaegers deleted the feature/consolidate-formatting branch September 27, 2024 10:14
Copy link
Contributor

Pull Request Report (#582)

Static measures

Description Value
Number of added lines 398
Number of deleted lines 46
Number of changed files 11
Number of commits 8
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 23.9 Hours
Time that was spend on the branch before the PR was created 41 Sec
Time that was spend on the branch before the PR was merged 23.9 Hours
Time to merge after last review 21 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 17 Min
Total time spend in last status check run on PR 1.9 Hours

Copy link
Contributor

github-actions bot commented Oct 9, 2024

🎉 Hooray! The changes in this pull request went live with the release of v5.3.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants