fix: decouple host and embedded builds #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since protobuf is now statically linked we don't need to extend the path
The embedded build no longer depends on the availability of a host build of emil. Protocol buffer compiler plug-ins for echo are fetched from GitHub releases on-demand when building for embedded. In case of a host build the built compiler plug-ins are used.
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 11 | 0 | 0.05s | |
| ✅ DOCKERFILE | hadolint | 1 | 0 | 0.07s | |
| ✅ JSON | eslint-plugin-jsonc | 10 | 0 | 0 | 1.5s |
| ✅ JSON | prettier | 10 | 0 | 0 | 0.7s |
| markdownlint | 7 | 0 | 11 | 0.66s | |
| markdown-link-check | 7 | 1 | 32.11s | ||
| ✅ MARKDOWN | markdown-table-formatter | 7 | 0 | 0 | 0.45s |
| ✅ SPELL | misspell | 37 | 0 | 0 | 0.22s |
| ✅ YAML | prettier | 19 | 0 | 0 | 1.18s |
| ✅ YAML | v8r | 19 | 0 | 6.93s | |
| ✅ YAML | yamllint | 19 | 0 | 0.35s |
See detailed report in MegaLinter reports
MegaLinter is graciously provided by
…ithub.com/philips-software/amp-embedded-infra-lib into feature/decouple-host-and-embedded-builds
rjaegers
commented
Apr 19, 2023
richardapeters
approved these changes
Apr 19, 2023
rjaegers
commented
Apr 19, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building for embedded targets it is no longer needed to first do a host build of amp-embedded-infra-lib.
Details
When using the Echo (RPC) framework based on Google Protocol Buffers, the compiler and compiler plug-ins are fetched from GitHub releases on-demand when building for embedded targets.
In case of a host build the built compiler plug-ins are used, in case of an embedded build the plug-ins are either consumed from a local amp-embedded-infra-lib install or downloaded via FetchContent.
How to use installed echo plug-ins
When wanting to use locally built echo plug-ins in either amp-embedded-infra-lib or a consuming project (i.e. a project using amp-embedded-infra-lib) when doing an embedded build; it is necessary to:
installdirectory)