-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ExecuteUntil to event dispatchers, add EventDispatcherThreadAware #526
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ ACTION | actionlint | 12 | 0 | 0.06s | |
✅ CPP | clang-format | 939 | 2 | 0 | 6.26s |
✅ DOCKERFILE | hadolint | 2 | 0 | 0.1s | |
✅ JSON | eslint-plugin-jsonc | 8 | 0 | 0 | 2.84s |
✅ JSON | jsonlint | 8 | 0 | 0.13s | |
✅ JSON | prettier | 8 | 0 | 0 | 0.6s |
markdownlint | 6 | 0 | 4 | 1.54s | |
markdown-link-check | 6 | 1 | 42.6s | ||
✅ MARKDOWN | markdown-table-formatter | 6 | 0 | 0 | 0.38s |
✅ REPOSITORY | checkov | yes | no | 20.82s | |
✅ REPOSITORY | git_diff | yes | no | 0.07s | |
✅ REPOSITORY | grype | yes | no | 17.03s | |
✅ REPOSITORY | secretlint | yes | no | 6.89s | |
✅ REPOSITORY | trivy | yes | no | 9.29s | |
✅ REPOSITORY | trivy-sbom | yes | no | 1.38s | |
✅ REPOSITORY | trufflehog | yes | no | 4.11s | |
lychee | 135 | 3 | 1.83s | ||
prettier | 22 | 0 | 1 | 1.25s | |
✅ YAML | v8r | 22 | 0 | 12.23s | |
✅ YAML | yamllint | 22 | 0 | 0.4s |
See detailed report in MegaLinter reports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current ExecuteUntil functions should take an templates Predicate. This allows the caller to provide a lambda with more captures than what infra:: Function allows.
Much like how the Subject/Observer Notify functions work.
Co-authored-by: Daan Timmer <8293597+daantimmer@users.noreply.github.com>
Co-authored-by: Daan Timmer <8293597+daantimmer@users.noreply.github.com>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Using infra::Function avoids having a method template, and is in line with how amp-embedded-infra-lib uses functions. I am still considering adding an interface on top of Run/ExecuteAllActions/ExecuteUntil somewhere in the future; that requires ExecuteUntil to not be a method template. |
No description provided.