Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect connection handle in state transitions #147

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

andjordan
Copy link
Contributor

@andjordan andjordan commented Jun 6, 2023

A requested transition from Standby to Advertise to Standby from the product would stay in Advertise state

@andjordan andjordan requested a review from a team as a code owner June 6, 2023 12:42
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR. We really appreciate it!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.07s
⚠️ MARKDOWN markdownlint 20 14 2 1.44s
⚠️ MARKDOWN markdown-link-check 20 13 30.6s
✅ MARKDOWN markdown-table-formatter 20 14 0 0.98s
✅ REPOSITORY checkov yes no 16.72s
✅ REPOSITORY dustilock yes no 0.04s
✅ REPOSITORY gitleaks yes no 72.89s
✅ REPOSITORY git_diff yes no 1.02s
✅ REPOSITORY kics yes no 22.16s
✅ REPOSITORY secretlint yes no 22.78s
✅ REPOSITORY syft yes no 0.56s
✅ REPOSITORY trivy yes no 4.81s
✅ XML xmllint 17 0 0 0.81s
✅ YAML prettier 7 1 0 1.48s
✅ YAML v8r 7 0 6.26s
✅ YAML yamllint 7 0 0.36s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@andjordan andjordan marked this pull request as draft June 7, 2023 08:53
@andjordan andjordan changed the title fix: transitions to/from standby fix: incorrect connection handle in state transitions Jun 7, 2023
@andjordan andjordan marked this pull request as ready for review June 7, 2023 10:58
@andjordan andjordan requested a review from EkelmansPh June 8, 2023 09:04
@andjordan andjordan merged commit 2f99452 into main Jun 8, 2023
@andjordan andjordan deleted the feature/fix_standby_transition branch June 8, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants