Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move starting the DAC channel to the constructor to avoid a 1ms delay loop every time the Dac value is set #387

Merged

Conversation

daantimmer
Copy link
Contributor

@daantimmer daantimmer commented Aug 23, 2024

There is a 1ms delay in the HAL_DAC_Start function provided by ST. This is required for correct DAC startup behaviour.

However, it is not required to this every time a value is set. I propose to move the HAL_DAC_Start and related initialization code to when the DAC instance is instantiated, instead of every time a value is set.

@daantimmer daantimmer requested a review from a team as a code owner August 23, 2024 15:10
Copy link
Contributor

github-actions bot commented Aug 23, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.01s
✅ CPP clang-format 15 2 0 0.14s
✅ DOCKERFILE hadolint 1 0 0.08s
✅ JSON jsonlint 7 0 0.12s
✅ JSON prettier 7 2 0 0.69s
⚠️ MARKDOWN markdownlint 6 1 7 1.14s
⚠️ MARKDOWN markdown-link-check 6 2 47.18s
✅ MARKDOWN markdown-table-formatter 6 1 0 0.23s
✅ REPOSITORY checkov yes no 26.59s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 21.9s
✅ REPOSITORY ls-lint yes no 0.06s
✅ REPOSITORY secretlint yes no 54.53s
✅ REPOSITORY trivy yes no 5.58s
✅ REPOSITORY trivy-sbom yes no 0.73s
✅ REPOSITORY trufflehog yes no 10.4s
⚠️ SPELL lychee 30 2 87.32s
✅ YAML prettier 8 2 0 0.72s
✅ YAML v8r 8 0 7.56s
✅ YAML yamllint 8 0 0.24s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@daantimmer daantimmer enabled auto-merge (squash) September 2, 2024 05:36
@daantimmer daantimmer merged commit 8211b8c into main Sep 2, 2024
25 checks passed
@daantimmer daantimmer deleted the feature/configure-DigitalToAnalogPinStm-peripheral-in-ctor branch September 2, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants