-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update font size and line height to vh, resolve #2 #34
fix: Update font size and line height to vh, resolve #2 #34
Conversation
This is great! Is there any way we could make the font sizes a little bit larger? I like how the blocks of text are a little bit closer to each other on what we currently have in production — it contributes to that brütalist vibe. |
Updated the size. Let me know if it changes. |
Looking good! I'd suggest we get as close to where we were before as possible, just with the clamps making things look better on atypical screen sizes. I played around with this and got pretty close, but I'll leave it up to you as to what looks best:
Could we reduce the height of |
@chethtrayen I think the structure you've put in place is perfect — on my machine, on Chrome, there's a bit of a difference still between production and this branch: Are you also seeing that on your end? |
701327d
to
6fae433
Compare
Ping @chethtrayen - is this still something you're interested in? |
Closing out to keep the queue clear in case someone else wants to work on this. LMK if you want to resume! But no worries if you don't have time. 🙂 |
PR Checklist
status: accepting prs
Overview
Updated font size and line height to use vh rather than rem. While zooming, the text will not overlap each other and scale accordingly.
Screenshot
Spec:
Resolution: 1069x490
Zoom: 200%