Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Uplift to dotnet 6.0 #200

Closed
philosowaffle opened this issue Jan 17, 2022 · 4 comments · Fixed by #264
Closed

[Feature] Uplift to dotnet 6.0 #200

philosowaffle opened this issue Jan 17, 2022 · 4 comments · Fixed by #264
Assignees
Labels
enhancement new feature / improvments WIP

Comments

@philosowaffle
Copy link
Owner

  • Uplift both Console and WebApp to dotnet 6.
  • Bump dependency versions as well
@philosowaffle philosowaffle added enhancement new feature / improvments Console issues/features impacting the Console application Web UI issues/features impacting the Web application labels Jan 17, 2022
@philosowaffle
Copy link
Owner Author

It's occurred to me this may be a breaking change for many folks. I believe they would have to download and install the dotnet 6 runtime. Currently the docs say to install dotnet 5 runtime. It's trivial to install the latest runtime, but its still a breaking change nonetheless. Probably hold off on this for a bit, atleast until there is a next major release planned..

@philosowaffle philosowaffle removed the Web UI issues/features impacting the Web application label Mar 27, 2022
@eRaid6
Copy link

eRaid6 commented Jun 8, 2022

Is there a timeline for this change? I recently installed Fedora 36 and it only ships with dotnet 6.0 [0] since dotnet 5.0 is EOL as of May 10th, 2022 [1]. I noticed the Wiki has been updated to say install dotnet 6.0 [2] but I get the following error when trying to run it on 6.

[user@fedora36 ~/git/peloton-to-garmin-v2/peloton-to-garmin] :) dotnet run --project ./src/PelotonToGarminConsole/PelotonToGarminConsole.csproj
It was not possible to find any compatible framework version
The framework 'Microsoft.AspNetCore.App', version '5.0.0' (x64) was not found.
  - The following frameworks were found:
      6.0.5 at [/usr/lib64/dotnet/shared/Microsoft.AspNetCore.App]

You can resolve the problem by installing the specified framework and/or SDK.

The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.AspNetCore.App&framework_version=5.0.0&arch=x64&rid=fedora.36-x64
[user@fedora36 ~/git/peloton-to-garmin-v2/peloton-to-garmin] :(

[0] https://src.fedoraproject.org/rpms/dotnet5.0/c/92b338dba74fe52ecd6e8d515e1255356b8aeb59?branch=rawhide
[1] https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core#lifecycle
[2] https://philosowaffle.github.io/peloton-to-garmin/install/source.html

@philosowaffle philosowaffle added WIP and removed blocked Console issues/features impacting the Console application labels Jun 9, 2022
@philosowaffle philosowaffle self-assigned this Jun 9, 2022
This was referenced Jun 9, 2022
@philosowaffle
Copy link
Owner Author

Latest version of the code should be on dotnet 6 now. I have a few more tasks though (documented in #263) before I can cut a new release with these changes.

@eRaid6
Copy link

eRaid6 commented Jun 9, 2022

I can confirm the latest commit has fixed the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature / improvments WIP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants