Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update roslyn workspace 4.4.0 #220

Merged
merged 1 commit into from
Nov 29, 2022
Merged

update roslyn workspace 4.4.0 #220

merged 1 commit into from
Nov 29, 2022

Conversation

colombod
Copy link
Contributor

No description provided.

@daveaglick
Copy link
Collaborator

@psfinaki and @0xced - do either of you see any issues with this retarget for Stryker consumption? Is it able to consume a .NET 7 library?

@cslong Same question for the AWS stuff?

@alfonsogarciacaro And for Fable?

Just figured I'd check with some of the bigger consumers I know about before a big retarget like this. Thanks all (and thanks @colombod for getting the ball rolling)!

@psfinaki
Copy link
Contributor

Well Stryker definitely works with .NET 7, so AFAIU this should be fine (and maybe even helpful), @richardwerkman correct me if I am wrong.

@richardwerkman
Copy link

Stryker runs on .NET 6 at the moment and we try to only update to LTS versions. So that means we would skip V7. Currently, we can't consume .NET 7 packages. @psfinaki it's true stryker works on .NET 7 projects but it runs on .NET 6.

@psfinaki
Copy link
Contributor

Alright, sorry for misleading then, good that I asked :)

@colombod
Copy link
Contributor Author

colombod commented Nov 29, 2022 via email

@rouke-broersma
Copy link

Is net6 required for roslyn workspaces 4.4? If not I think this should probably be a separate change. It's also a huge bump from 3.1, and makes it so this library can't be consumed by < net6 so probably a breaking change.

I don't personally disagree with that as netcore3.1 is EOL but it does limit potential consumers and shouldn't be taken lightly, imo.

@colombod colombod changed the title update to .net7 and roslyn workspace 4.4.0 update to .net 6.0 and roslyn workspace 4.4.0 Nov 29, 2022
@colombod
Copy link
Contributor Author

colombod commented Nov 29, 2022

Is net6 required for roslyn workspaces 4.4? If not I think this should probably be a separate change. It's also a huge bump from 3.1, and makes it so this library can't be consumed by < net6 so probably a breaking change.

I don't personally disagree with that as netcore3.1 is EOL but it does limit potential consumers and shouldn't be taken lightly, imo.

Is not strictly needed but did it because of EOL for 3.1 I'd prefer to move to LTS version

@rouke-broersma
Copy link

Is not strictly needed but did it because of EOL for 3.1

In that case I think a separate pr is cleaner.

@daveaglick
Copy link
Collaborator

Go team! Thanks for the input everyone, glad I surfaced this one to the community.

In that case I think a separate pr is cleaner.

I agree, and in general I try to stick to the lowest possible target to allow the largest number of consumers. I've been on the consumption end where I'm unable to update my own targeting so I appreciate when projects don't retarget just for retargeting sake.

@colombod let's do this:

  • Microsoft.CodeAnalysis.CSharp.Workspaces 4.4.0 only has a dependency on .NET Core 3.1, so let's make this PR just for that update. Then I can get a release out with the updated workspaces library.
  • Separately let's do an update to .NET 6 as the latest LTS since .NET Core 3.1 is falling out of support in a couple weeks. That should let Stryker (one of our most active contributors) continue to consume without issue while bumping us to a supported platform. By separating the PRs and releases we can also let anyone who needs to stay on .NET Core 3.1 get the workspaces update and then hang out on that release.

Sound good?

@colombod
Copy link
Contributor Author

Good let me do that in few minutes

@colombod colombod changed the title update to .net 6.0 and roslyn workspace 4.4.0 update roslyn workspace 4.4.0 Nov 29, 2022
target .NET 6.0


revert to target 3.1
@daveaglick
Copy link
Collaborator

Fantastic, thanks! Merging in and doing a release now (it'll take about an hour to run through local tests prior to deployment).

@daveaglick daveaglick merged commit 9bd8874 into phmonte:main Nov 29, 2022
@colombod colombod deleted the upgrades branch November 29, 2022 19:16
@colombod
Copy link
Contributor Author

@daveaglick I split to #221

@daveaglick
Copy link
Collaborator

Buildalyzer 4.1.7 (and related libraries) with this change to the workspaces dependency have been published to NuGet. I'll work on #221 as Buildalyzer version 4.2.0 next (I like to bump the first minor version number on any targeting changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants