Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker stops propagation #38

Closed
c7pt7in opened this issue Jun 30, 2017 · 2 comments
Closed

Picker stops propagation #38

c7pt7in opened this issue Jun 30, 2017 · 2 comments
Labels
⚒️ enhancement Enhancements ✅ released Already released

Comments

@c7pt7in
Copy link

c7pt7in commented Jun 30, 2017

I have datepicker, and when I select date and click on timepicker, datepicker not closing because timepicker stops propagation.

I also have multiple timepickers in same component and everything works fine when I remove .stop from dist code. So, you should revert #3

@rubencanovaca
Copy link

Using stopEventPropagation() is something that should be avoided as it breaks normal event flow in the DOM.

@phoenixwong phoenixwong added ⚒️ enhancement Enhancements 🚥 next release Included in the next release labels Aug 9, 2019
@phoenixwong phoenixwong added ✅ released Already released and removed 🚥 next release Included in the next release labels Aug 9, 2019
@phoenixwong
Copy link
Owner

Enhancement released in v0.2.1

The @click.stop handler is only added to the dropdown picker now. Aimed to prevent the dropdown from closing on every value selection.

Click events will pass on the parent container in other circumstances.

For those who want to stop all click events propagation from <vue-timepicker>, please try

<vue-timepicker @click.native.stop=""></vue-timepicker>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚒️ enhancement Enhancements ✅ released Already released
Projects
None yet
Development

No branches or pull requests

3 participants