This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Prevent windows toast notification when in foreground #145
Comments
For those that found this thread and want to do this manually (if this is not approved/merged):
|
Hi @Deathspike , Thanks for the detailed issue. Though you make a valid point, but by doing so we will be kicking away the default handling of the notifications by the windows OS, which most of the users might prefer rather than implementing it on their own. As you have already mentioned, the users who want to achieve that can do so by setting the cancel property to true. |
@rakatyal we should probably add that to the readme under Windows. |
Sure. Will do that. |
This thread has been automatically locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When receiving a notification in the foreground, the platforms behave as followed:
Unlike Android and iOS, Windows does show a system notification even if it is handled. This essentially means that the notification can be fired twice, and that can and will break assumptions. In the spirit of normalizing the differences between the platforms, I propose a change to stop the toast notification when handling a foreground notification on the Windows platform.
Change:
To:
On https://github.com/phonegap/phonegap-plugin-push/blob/master/src/windows/PushPluginProxy.js#L53
The text was updated successfully, but these errors were encountered: