Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Refactor key extraction into configuration file #230

Open
macdonst opened this issue Oct 14, 2015 · 3 comments
Open

Refactor key extraction into configuration file #230

macdonst opened this issue Oct 14, 2015 · 3 comments

Comments

@macdonst
Copy link
Member

Different push services end up naming their keys differently or putting the keys in different sub objects. We should refactor the key extraction code so that it loads the key definitions from a configuration file so that we can support more backend push services easier.

@macdonst
Copy link
Member Author

@smdvdsn let's use the issue230 branch to collaborate on it. I wanna finish out release 1.4.0 first but then I will get on this.

@smdvdsn
Copy link
Collaborator

smdvdsn commented Oct 14, 2015

ok thanks @macdonst One thing I wanted to ask is do you want to support everything out of the box? So as new providers are discovered are you thinking that the default config on master would be updated to include the new keys or do you want to only support the basic keys and then allow people to configure from there?

The main reason I ask is about backwards compatibility. Basically merging #220 as is might lock us into supporting these providers in future versions. Then again I could just be over thinking it.

@macdonst
Copy link
Member Author

Let's put everything into the configuration file for now. I like to make it as easy as possible for people to pick up this plugin and get going. If it becomes too crazy to support then we drop it during a major version as we can call it a breaking change at that point and just document the crap out of it.

@macdonst macdonst added this to the Release 1.5.0 milestone Oct 26, 2015
@macdonst macdonst modified the milestones: Release 1.6.0, Release 1.5.0 Dec 14, 2015
@macdonst macdonst modified the milestones: Release 1.7.0, Release 1.6.0 Feb 29, 2016
@macdonst macdonst modified the milestones: Release 2.0.0, Release 1.7.0 May 27, 2016
@fredgalvao fredgalvao mentioned this issue Nov 22, 2016
21 tasks
@macdonst macdonst modified the milestones: Release 2.0.0, Release 2.1.0 Sep 6, 2017
@macdonst macdonst removed this from the Release 2.1.0 milestone Oct 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants