New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review #2

Open

iamloivx opened this issue Apr 24, 2017 · 1 comment

iamloivx commented Apr 24, 2017

Multiple meaningless null checks

Example: https://github.com/phongnt570/UETsegmenter/blob/master/src/vn/edu/vnu/uet/nlp/tokenizer/Tokenizer.java#L25

s can not be null. You already call s before.

String[] tempTokens = s.split("(\\s| )+");

if (trimed.isEmpty() || trimed.equals(StringConst.SPACE) || s == null || tempTokens.length == 0) {
     return tokens;
}

The text was updated successfully, but these errors were encountered:

Owner

phongnt570 commented Apr 24, 2017

Thanks for your useful feedback. I am revising to clean the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment