Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share utilities between features #4

Closed
phorcys420 opened this issue Jul 5, 2024 · 1 comment
Closed

Share utilities between features #4

phorcys420 opened this issue Jul 5, 2024 · 1 comment

Comments

@phorcys420
Copy link
Owner

phorcys420 commented Jul 5, 2024

There should be a shared library between features that contains the following :

  • check_packages
  • A function to get a GH release link based on tag or get latest (like what's done in the Ghidra feature)

There is currently a proposal for sharing code between features but we would need something else in the mean time.

We can either download the library from the feature's script via curl and pin it using the commit ID but that's not great.
I think a better thing would be to have another feature that only serves as a library and then loading it via dependsOn in each separate feature.

@phorcys420
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant