Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find package on node 20 #88

Closed
kareljan opened this issue Apr 1, 2024 · 6 comments
Closed

Cannot find package on node 20 #88

kareljan opened this issue Apr 1, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@kareljan
Copy link

kareljan commented Apr 1, 2024

Describe the bug

When I try to use the icons in a nextjs project on node 20.12.0 I get the following error.

Cannot find package '/pathtoproject/node_modules/@phosphor-icons/react/dist/node_modules/.pnpm/react@18.2.0/node_modules/react/package.json'

Steps to Reproduce

Try using it in a node 20 react project

Expected behavior

No errors

Context (please complete the following information):

  • OS: Mac OS 14.4
  • @phosphor-icons/react
  • Version 2.1.4
@kareljan kareljan added the bug Something isn't working label Apr 1, 2024
@rektdeckard
Copy link
Member

I just created a fresh React/Typescript/Vite/Node 20.12.0 project and have no issues, so I suspect this may be specific to NextJS...as usual.

Can you share a minimal reproduction I can test against? StackBlitz doesn't support Node 20 just yet, but maybe a GitHub Codespace or something? Thanks.

@KarelJanVanHaute
Copy link

Hey @rektdeckard

For now, I don't seem to get it to break in a contained environment. I guess the problem lies deeper in my code.
I'll keep you posted if I find the cause of the problem.

@KarelJanVanHaute
Copy link

KarelJanVanHaute commented Apr 11, 2024

Hey @rektdeckard

You can find a minimal example of the error on https://supreme-space-orbit-rq9g7q4xqx3rpv.github.dev/
and on this link you can find a minimal example of the error in node 18 https://fantastic-broccoli-74pw7v6r7vw3w5x.github.dev/

@johnnyshankman
Copy link

johnnyshankman commented Apr 15, 2024

im having this issue as well. had to revert to 2.1.0 and suddenly from 2.1.4 no issue. Also on node v20. Also using vite + react, but issue only appears in vitest which is odd.

@johnnyshankman
Copy link

johnnyshankman commented Apr 15, 2024

#94 possibly related but opened separately

@rektdeckard
Copy link
Member

Identified to be same issue as #90. Closing as duplicate, but fix incoming!

@rektdeckard rektdeckard closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants