Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Removing the foreground widget from a tab panel causes it to be hidden #368

Open
quigleyj-mavenomics opened this issue Dec 14, 2018 · 2 comments

Comments

@quigleyj-mavenomics
Copy link

When removing the foreground widget from a tab panel, either by adding it to another region or sending it a close-request, the TabPanel will hide the foreground widget.

The culprit is the currentChanged handler in TabPanel, which hide()s the previous foreground widget without checking to see if the previous widget is still a child of the panel.

I have some free time this weekend, so I can submit PRs for this and #362 if you'd like.

@sccolbert
Copy link
Member

Thanks for reporting this!

@sccolbert
Copy link
Member

Although I wonder if previousTitle should be null for this case. i.e. the true bug might be in the tab bar. Perhaps the previousTitle should be null if it's already been removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants