Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFT Usage with Upgraded Pytorch Versions #361

Open
denproc opened this issue May 8, 2023 · 0 comments
Open

FFT Usage with Upgraded Pytorch Versions #361

denproc opened this issue May 8, 2023 · 0 comments
Labels
enhancement Making some part of the codebase better without introduction of new features feature New feature or request

Comments

@denproc
Copy link
Collaborator

denproc commented May 8, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Some metrics (FSIM, VSI, SR-SIM) use FFT related operations, which were changed in with torch==1.8.0.

CLIPIQA (#331 #348) requires torchvision>=0.10.1 and torch>=1.9.1, making the code that uses FFT cumbersome.

Describe the solution you'd like

  • I would suggest to keep the legacy code for next release and add warning message that older version of pytorch (<=1.8.0) might not work in future releases.
  • Remove legacy code in future release.
@denproc denproc added feature New feature or request enhancement Making some part of the codebase better without introduction of new features labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Making some part of the codebase better without introduction of new features feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@denproc