-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss the use of phovea_product.schema.json #445
Comments
The JSON Schema was added back then to describe the data format of the phovea_product.json. The problem in our setup is that the schema is not referenced in the actual JSON file. Vega also uses the JSON Schema to provide, for instance, auto-complete support and validation. {
"$schema": "https://vega.github.io/schema/vega/v5.json", // <- reference schema
"description": "A basic bar chart example, with value labels shown upon mouse hover.",
"width": 400,
"height": 200,
"padding": 5,
// ... The actual schema can then be found here: https://vega.github.io/schema/vega/v5.json Long story short: I'd rather not remove the phovea_product.schema.json, but go the extra mile and try the reference and maybe update our JSON schema. |
I discussed this issue also with @anita-steiner and we agreed to remove the schema file. |
The file
phovea_product.schema.json
is one of the files created when initializing a new product. From our investigation it is not used anywhere in the generator.@thinkh Do you know why we need this file in the product?
We would remove it if it is not used anywhere.
The text was updated successfully, but these errors were encountered: