remove native database types thing (#61)

Author: shmax

lib/Adapter/MysqlAdapter.php

@@ -88,24 +88,4 @@ public function accepts_limit_and_order_for_update_and_delete(): bool
     {
         return true;
     }
-
-    /**
-     * @return array<string, string|array<string, mixed>>
-     */
-    public function native_database_types(): array
-    {
-        return [
-            'primary_key' => 'int(11) UNSIGNED DEFAULT NULL auto_increment PRIMARY KEY',
-            'string' => ['name' => 'varchar', 'length' => 255],
-            'text' => ['name' => 'text'],
-            'integer' => ['name' => 'int', 'length' => 11],
-            'float' => ['name' => 'float'],
-            'datetime' => ['name' => 'datetime'],
-            'timestamp' => ['name' => 'datetime'],
-            'time' => ['name' => 'time'],
-            'date' => ['name' => 'date'],
-            'binary' => ['name' => 'blob'],
-            'boolean' => ['name' => 'tinyint', 'length' => 1]
-        ];
-    }
 }

lib/Adapter/PgsqlAdapter.php

@@ -135,21 +135,4 @@ public function set_encoding(string $charset): void
     {
         $this->query("SET NAMES '$charset'");
     }
-
-    public function native_database_types(): array
-    {
-        return [
-            'primary_key' => 'serial primary key',
-            'string' => ['name' => 'character varying', 'length' => 255],
-            'text' => ['name' => 'text'],
-            'integer' => ['name' => 'integer'],
-            'float' => ['name' => 'float'],
-            'datetime' => ['name' => 'datetime'],
-            'timestamp' => ['name' => 'timestamp'],
-            'time' => ['name' => 'time'],
-            'date' => ['name' => 'date'],
-            'binary' => ['name' => 'binary'],
-            'boolean' => ['name' => 'boolean']
-        ];
-    }
 }

lib/Adapter/SqliteAdapter.php

@@ -108,22 +108,4 @@ public function accepts_limit_and_order_for_update_and_delete(): bool
     {
         return true;
     }
-
-    public function native_database_types(): array
-    {
-        return [
-            'primary_key' => 'integer not null primary key',
-            'string' => ['name' => 'varchar', 'length' => 255],
-            'text' => ['name' => 'text'],
-            'integer' => ['name' => 'integer'],
-            'float' => ['name' => 'float'],
-            'decimal' => ['name' => 'decimal'],
-            'datetime' => ['name' => 'datetime'],
-            'timestamp' => ['name' => 'datetime'],
-            'time' => ['name' => 'time'],
-            'date' => ['name' => 'date'],
-            'binary' => ['name' => 'blob'],
-            'boolean' => ['name' => 'boolean']
-        ];
-    }
 }

lib/Connection.php

@@ -563,15 +563,6 @@ abstract public function query_for_tables(): \PDOStatement;
      */
     abstract public function set_encoding(string $charset): void;
 
-    /*
-     * Returns an array mapping of native database types
-     */
-
-    /**
-     * @return array<string, string|array<string, mixed>>
-     */
-    abstract public function native_database_types(): array;
-
     /**
      * Specifies whether adapter can use LIMIT/ORDER clauses with DELETE & UPDATE operations
      *

lib/Table.php

@@ -133,7 +133,7 @@ public function reestablish_connection(bool $close = true): Connection
         $connection = $this->class->getStaticPropertyValue('connection', null);
 
         if ($close) {
-            ConnectionManager::drop_connection($connection);
+            ConnectionManager::drop_connection($connection ?? '');
             static::clear_cache();
         }
 

test/ConnectionTest.php

@@ -74,4 +74,10 @@ public function testEncoding()
         $info = ActiveRecord\Connection::parse_connection_url('mysql://test:test@127.0.0.1/test?charset=utf8');
         $this->assertEquals('utf8', $info['charset']);
     }
+
+    public function testReestablishConnection()
+    {
+        $connection = \test\models\Book::reestablish_connection(true);
+        $this->assertNotNull($connection);
+    }
 }