refactor: move a method from CategoryController to SeriesController to reduce a coupling.

Fix #1053

Author: php-coder

src/main/java/ru/mystamps/web/feature/category/CategoryConfig.java

@@ -22,7 +22,6 @@
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
-import ru.mystamps.web.feature.series.SeriesService;
 
 /**
  * Spring configuration that is required for using categories in an application.
@@ -37,11 +36,10 @@ public class CategoryConfig {
 	public static class Controllers {
 
 		private final CategoryService categoryService;
-		private final SeriesService seriesService;
 
 		@Bean
 		public CategoryController categoryController() {
-			return new CategoryController(categoryService, seriesService);
+			return new CategoryController(categoryService);
 		}
 
 		@Bean

src/main/java/ru/mystamps/web/feature/category/CategoryController.java

@@ -32,8 +32,7 @@
 import org.springframework.web.servlet.view.RedirectView;
 import ru.mystamps.web.common.LinkEntityDto;
 import ru.mystamps.web.common.LocaleUtils;
-import ru.mystamps.web.feature.series.SeriesInfoDto;
-import ru.mystamps.web.feature.series.SeriesService;
+import ru.mystamps.web.feature.series.SeriesUrl;
 import ru.mystamps.web.support.spring.mvc.ReplaceRepeatingSpacesEditor;
 import ru.mystamps.web.support.spring.security.CurrentUser;
 
@@ -50,7 +49,6 @@
 public class CategoryController {
 
 	private final CategoryService categoryService;
-	private final SeriesService seriesService;
 
 	@InitBinder("addCategoryForm")
 	protected void initBinder(WebDataBinder binder) {
@@ -81,35 +79,7 @@ public String processInput(
 
 		redirectAttributes.addFlashAttribute("justAddedCategory", true);
 
-		return redirectTo(CategoryUrl.INFO_CATEGORY_PAGE, slug);
-	}
-	
-	// CheckStyle: ignore LineLength for next 1 line
-	// @todo #927 CategoryController: remove dependency on SeriesService by moving showInfoBySlug() method
-	@GetMapping(CategoryUrl.INFO_CATEGORY_PAGE)
-	public String showInfoBySlug(
-		@Category @PathVariable("slug") LinkEntityDto category,
-		Model model,
-		Locale userLocale,
-		HttpServletResponse response)
-		throws IOException {
-		
-		if (category == null) {
-			response.sendError(HttpServletResponse.SC_NOT_FOUND);
-			return null;
-		}
-		
-		String slug = category.getSlug();
-		String name = category.getName();
-		
-		String lang = LocaleUtils.getLanguageOrNull(userLocale);
-		List<SeriesInfoDto> series = seriesService.findByCategorySlug(slug, lang);
-		
-		model.addAttribute("categorySlug", slug);
-		model.addAttribute("categoryName", name);
-		model.addAttribute("seriesOfCategory", series);
-		
-		return "category/info";
+		return redirectTo(SeriesUrl.INFO_CATEGORY_PAGE, slug);
 	}
 
 	@GetMapping(CategoryUrl.INFO_CATEGORY_BY_ID_PAGE)
@@ -125,7 +95,7 @@ public View showInfoById(
 
 		RedirectView view = new RedirectView();
 		view.setStatusCode(HttpStatus.MOVED_PERMANENTLY);
-		view.setUrl(CategoryUrl.INFO_CATEGORY_PAGE);
+		view.setUrl(SeriesUrl.INFO_CATEGORY_PAGE);
 
 		return view;
 	}

src/main/java/ru/mystamps/web/feature/category/CategoryUrl.java

@@ -32,7 +32,6 @@ public final class CategoryUrl {
 	public static final String SUGGEST_SERIES_CATEGORY = "/suggest/series_category";
 	public static final String ADD_CATEGORY_PAGE       = "/category/add";
 	static final String GET_CATEGORIES_PAGE            = "/categories";
-	static final String INFO_CATEGORY_PAGE             = "/category/{slug}";
 
 	// For backward compatibility
 	static final String LIST_CATEGORIES_PAGE       = "/category/list";
@@ -44,7 +43,6 @@ private CategoryUrl() {
 	public static void exposeUrlsToView(Map<String, String> urls) {
 		urls.put("ADD_CATEGORY_PAGE", ADD_CATEGORY_PAGE);
 		urls.put("GET_CATEGORIES_PAGE", GET_CATEGORIES_PAGE);
-		urls.put("INFO_CATEGORY_PAGE", INFO_CATEGORY_PAGE);
 		urls.put("SUGGEST_SERIES_CATEGORY", SUGGEST_SERIES_CATEGORY);
 	}
 

src/main/java/ru/mystamps/web/feature/series/SeriesController.java

@@ -281,6 +281,32 @@ public String showInfoByCountrySlug(
 		return "country/info";
 	}
 
+	@GetMapping(SeriesUrl.INFO_CATEGORY_PAGE)
+	public String showInfoBySlug(
+		@Category @PathVariable("slug") LinkEntityDto category,
+		Model model,
+		Locale userLocale,
+		HttpServletResponse response)
+		throws IOException {
+		
+		if (category == null) {
+			response.sendError(HttpServletResponse.SC_NOT_FOUND);
+			return null;
+		}
+		
+		String slug = category.getSlug();
+		String name = category.getName();
+		
+		String lang = LocaleUtils.getLanguageOrNull(userLocale);
+		List<SeriesInfoDto> series = seriesService.findByCategorySlug(slug, lang);
+		
+		model.addAttribute("categorySlug", slug);
+		model.addAttribute("categoryName", name);
+		model.addAttribute("seriesOfCategory", series);
+		
+		return "category/info";
+	}
+	
 	@SuppressWarnings("checkstyle:parameternumber")
 	@PostMapping(path = SeriesUrl.ADD_IMAGE_SERIES_PAGE, params = "imageUrl")
 	public String processImageWithImageUrl(

src/main/java/ru/mystamps/web/feature/series/SeriesUrl.java

@@ -32,6 +32,7 @@ public final class SeriesUrl {
 	public static final String ADD_SERIES_PAGE          = "/series/add";
 	public static final String ADD_SERIES_ASK_PAGE      = "/series/{id}/ask";
 	public static final String INFO_SERIES_PAGE         = "/series/{id}";
+	public static final String INFO_CATEGORY_PAGE       = "/category/{slug}";
 	public static final String INFO_COUNTRY_PAGE        = "/country/{slug}";
 	public static final String ADD_IMAGE_SERIES_PAGE    = "/series/{id}/image";
 	public static final String SERIES_INFO_PAGE_REGEXP  = "/series/(\\d+|\\d+/(ask|image))";
@@ -48,6 +49,7 @@ public static void exposeUrlsToView(Map<String, String> urls) {
 		urls.put("ADD_IMAGE_SERIES_PAGE", ADD_IMAGE_SERIES_PAGE);
 		urls.put("ADD_SERIES_ASK_PAGE", ADD_SERIES_ASK_PAGE);
 		urls.put("ADD_SERIES_PAGE", ADD_SERIES_PAGE);
+		urls.put("INFO_CATEGORY_PAGE", INFO_CATEGORY_PAGE);
 		urls.put("INFO_COUNTRY_PAGE", INFO_COUNTRY_PAGE);
 		urls.put("INFO_SERIES_PAGE", INFO_SERIES_PAGE);
 		urls.put("SEARCH_SERIES_BY_CATALOG", SEARCH_SERIES_BY_CATALOG);