Skip to content

Commit 4a1c672

Browse files
php-coderphp-coder
committed
refactor(Url): reduce visibility of most of the constants to private.
Addressed to #927 No functional changes.
1 parent c8942b2 commit 4a1c672

File tree

1 file changed

+25
-24
lines changed

1 file changed

+25
-24
lines changed

‎src/main/java/ru/mystamps/web/Url.java

Lines changed: 25 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -40,42 +40,43 @@
4040
* @author Slava Semushin
4141
*/
4242
public final class Url {
43-
public static final String STATIC_RESOURCES_URL = "https://stamps.filezz.ru";
43+
44+
// see also src/main/resources/application-test.properties
45+
public static final String H2_CONSOLE_PAGE = "/console";
4446

4547
// MUST be updated when any of our resources were modified
46-
public static final String RESOURCES_VERSION = "v0.3.13";
48+
public static final String RESOURCES_VERSION = "v0.3.13";
49+
50+
private static final String STATIC_RESOURCES_URL = "https://stamps.filezz.ru";
4751

4852
// CheckStyle: ignore LineLength for next 7 lines
49-
public static final String MAIN_CSS = "/static/" + RESOURCES_VERSION + "/styles/main.min.css";
50-
public static final String CATALOG_UTILS_JS = "/public/js/" + RESOURCES_VERSION + "/CatalogUtils.min.js"; // NOPMD: AvoidDuplicateLiterals
51-
public static final String DATE_UTILS_JS = "/public/js/" + RESOURCES_VERSION + "/DateUtils.min.js"; // NOPMD: AvoidDuplicateLiterals
52-
public static final String PARTICIPANT_ADD_JS = "/public/js/" + RESOURCES_VERSION + "/participant/add.min.js"; // NOPMD: AvoidDuplicateLiterals
53-
public static final String SERIES_ADD_JS = "/public/js/" + RESOURCES_VERSION + "/series/add.min.js"; // NOPMD: AvoidDuplicateLiterals
54-
public static final String SERIES_INFO_JS = "/public/js/" + RESOURCES_VERSION + "/series/info.min.js"; // NOPMD: AvoidDuplicateLiterals
55-
public static final String COLLECTION_INFO_JS = "/public/js/" + RESOURCES_VERSION + "/collection/info.min.js"; // NOPMD: AvoidDuplicateLiterals
56-
public static final String FAVICON_ICO = "/favicon.ico";
53+
private static final String MAIN_CSS = "/static/" + RESOURCES_VERSION + "/styles/main.min.css";
54+
private static final String CATALOG_UTILS_JS = "/public/js/" + RESOURCES_VERSION + "/CatalogUtils.min.js"; // NOPMD: AvoidDuplicateLiterals
55+
private static final String DATE_UTILS_JS = "/public/js/" + RESOURCES_VERSION + "/DateUtils.min.js"; // NOPMD: AvoidDuplicateLiterals
56+
private static final String PARTICIPANT_ADD_JS = "/public/js/" + RESOURCES_VERSION + "/participant/add.min.js"; // NOPMD: AvoidDuplicateLiterals
57+
private static final String SERIES_ADD_JS = "/public/js/" + RESOURCES_VERSION + "/series/add.min.js"; // NOPMD: AvoidDuplicateLiterals
58+
private static final String SERIES_INFO_JS = "/public/js/" + RESOURCES_VERSION + "/series/info.min.js"; // NOPMD: AvoidDuplicateLiterals
59+
private static final String COLLECTION_INFO_JS = "/public/js/" + RESOURCES_VERSION + "/collection/info.min.js"; // NOPMD: AvoidDuplicateLiterals
60+
private static final String FAVICON_ICO = "/favicon.ico";
5761

5862
// CheckStyle: ignore LineLength for next 4 lines
59-
public static final String BOOTSTRAP_CSS = "/public/bootstrap/3.4.1/css/bootstrap.min.css";
60-
public static final String BOOTSTRAP_JS = "/public/bootstrap/3.4.1/js/bootstrap.min.js";
61-
public static final String JQUERY_JS = "/public/jquery/1.9.1/jquery.min.js";
62-
public static final String BOOTSTRAP_LANGUAGE = "https://cdn.jsdelivr.net/gh/usrz/bootstrap-languages@3ac2a3d2b27ac43a471cd99e79d378a03b2c6b5f/languages.min.css";
63+
private static final String BOOTSTRAP_CSS = "/public/bootstrap/3.4.1/css/bootstrap.min.css";
64+
private static final String BOOTSTRAP_JS = "/public/bootstrap/3.4.1/js/bootstrap.min.js";
65+
private static final String JQUERY_JS = "/public/jquery/1.9.1/jquery.min.js";
66+
private static final String BOOTSTRAP_LANGUAGE = "https://cdn.jsdelivr.net/gh/usrz/bootstrap-languages@3ac2a3d2b27ac43a471cd99e79d378a03b2c6b5f/languages.min.css";
6367

6468
// CheckStyle: ignore LineLength for next 3 lines
6569
// FIXME: use minimal version of CSS file when it will be available (https://github.com/webjars/selectize.js/issues/3)
66-
public static final String SELECTIZE_CSS = "/public/selectize/0.12.5/css/selectize.bootstrap3.css";
67-
public static final String SELECTIZE_JS = "/public/selectize/0.12.5/js/standalone/selectize.min.js";
70+
private static final String SELECTIZE_CSS = "/public/selectize/0.12.5/css/selectize.bootstrap3.css";
71+
private static final String SELECTIZE_JS = "/public/selectize/0.12.5/js/standalone/selectize.min.js";
6872

6973
// see also pom.xml and ru.mystamps.web.config.MvcConfig#addResourceHandlers()
7074
// CheckStyle: ignore LineLength for next 5 lines
71-
public static final String BOOTSTRAP_CSS_CDN = "https://maxcdn.bootstrapcdn.com/bootstrap/3.4.1/css/bootstrap.min.css";
72-
public static final String BOOTSTRAP_JS_CDN = "https://maxcdn.bootstrapcdn.com/bootstrap/3.4.1/js/bootstrap.min.js";
73-
public static final String JQUERY_JS_CDN = "https://yandex.st/jquery/1.9.1/jquery.min.js";
74-
public static final String SELECTIZE_CSS_CDN = "https://cdnjs.cloudflare.com/ajax/libs/selectize.js/0.12.4/css/selectize.bootstrap3.min.css";
75-
public static final String SELECTIZE_JS_CDN = "https://cdnjs.cloudflare.com/ajax/libs/selectize.js/0.12.4/js/standalone/selectize.min.js";
76-
77-
// see also src/main/resources/application-test.properties
78-
public static final String H2_CONSOLE_PAGE = "/console";
75+
private static final String BOOTSTRAP_CSS_CDN = "https://maxcdn.bootstrapcdn.com/bootstrap/3.4.1/css/bootstrap.min.css";
76+
private static final String BOOTSTRAP_JS_CDN = "https://maxcdn.bootstrapcdn.com/bootstrap/3.4.1/js/bootstrap.min.js";
77+
private static final String JQUERY_JS_CDN = "https://yandex.st/jquery/1.9.1/jquery.min.js";
78+
private static final String SELECTIZE_CSS_CDN = "https://cdnjs.cloudflare.com/ajax/libs/selectize.js/0.12.4/css/selectize.bootstrap3.min.css";
79+
private static final String SELECTIZE_JS_CDN = "https://cdnjs.cloudflare.com/ajax/libs/selectize.js/0.12.4/js/standalone/selectize.min.js";
7980

8081
private Url() {
8182
}

0 commit comments

Comments
 (0)