chore: remove a couple TODOs about @SqlMergeMode

php-coder · php-coder · commit a5509b802b7c · 2022-11-15T11:48:47.000+07:00
I've decied to not use @SqlMergeMode as implicit is better than explicit. At this moment, every test explicitly requires its dependencies and I'd like to keep this. If we "merge" everything together, than it won't be clear what records is needed (and affects) what test. Part of #1149
diff --git a/src/test/java/ru/mystamps/web/feature/category/JdbcCategoryDaoTest.java b/src/test/java/ru/mystamps/web/feature/category/JdbcCategoryDaoTest.java
@@ -55,7 +55,6 @@ public void getStatisticsOfWithEmptyCollection() {
 		assertThat(statistics).isEmpty();
 	}
 	
-	// LATER: extract all "scripts" to a class level. Requires @SqlMergeMode from Spring 5.2
 	@Test
 	@Sql(
 		scripts = {
diff --git a/src/test/java/ru/mystamps/web/feature/country/JdbcCountryDaoTest.java b/src/test/java/ru/mystamps/web/feature/country/JdbcCountryDaoTest.java
@@ -119,7 +119,6 @@ public void getStatisticsOfWithEmptyCollection() {
 		assertThat(statistics).isEmpty();
 	}
 	
-	// LATER: extract all "scripts" to a class level. Requires @SqlMergeMode from Spring 5.2
 	@Test
 	@Sql(
 		scripts = {

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,6 @@ public void getStatisticsOfWithEmptyCollection() {`
`55`	`55`	`assertThat(statistics).isEmpty();`
`56`	`56`	`}`
`57`	`57`
`58`		`- // LATER: extract all "scripts" to a class level. Requires @SqlMergeMode from Spring 5.2`
`59`	`58`	`@Test`
`60`	`59`	`@Sql(`
`61`	`60`	`scripts = {`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,6 @@ public void getStatisticsOfWithEmptyCollection() {`
`119`	`119`	`assertThat(statistics).isEmpty();`
`120`	`120`	`}`
`121`	`121`
`122`		`- // LATER: extract all "scripts" to a class level. Requires @SqlMergeMode from Spring 5.2`
`123`	`122`	`@Test`
`124`	`123`	`@Sql(`
`125`	`124`	`scripts = {`