Skip to content

SeriesServiceImpl.findBy(Collection): add unit tests #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Sep 9, 2014 · 1 comment
Closed

SeriesServiceImpl.findBy(Collection): add unit tests #36

php-coder opened this issue Sep 9, 2014 · 1 comment
Assignees
@php-coder
Labels
area/unit tests techdebt
Milestone
0.4

Comments

@php-coder
Copy link
Owner

  • exception should be thrown if collection is null
  • exception should be thrown if collection id is null
  • should call seriesDao.findByAsSeriesInfo() and pass collection id and lang as arguments
  • should pass null when lang is null

Technical Debt for: 227b9a5 (#2)
@php-coder php-coder added this to the 0.4 milestone Jan 12, 2015
@php-coder php-coder self-assigned this Jan 12, 2015
@php-coder
Copy link
Owner Author

should pass null when lang is null test wasn't implemented because it looks superfluous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/unit tests techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@php-coder