Skip to content

StepDefinitions.addSeriesToCollection(): remove unused code #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
php-coder opened this issue Sep 25, 2017 · 1 comment
Closed

StepDefinitions.addSeriesToCollection(): remove unused code #642

php-coder opened this issue Sep 25, 2017 · 1 comment

Comments

@php-coder
Copy link
Owner

As far I understand, the following code removes a series from user's collection if the series is already belonging to a collection:

if (driver.findElements(By.id("series-danger")).size() != 0) {
driver.findElement(By.id("series-danger")).click();
driver.get(Url.SITE);
driver.findElement(By.linkText("1 item(s)")).click();
}

While it was useful during debugging, we don't need it because it's supposed that a test is always running on a clean state (fresh database). I feel that we can remove this code.

Tech debt for f72c87d (#46)

@php-coder
Copy link
Owner Author

Won't fix as we're going get rid of Cucumber JVM (#1019).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants