You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Stringexpected = "Series is part of your collection";
assertEquals(expected, actual);
Instead of what it is doing now, it should:
check that the message Series has been added to your collection is presented on the current page (hint: find an element with this message by a class name)
find a link near the label "new" and inspect its href attribute (is should equal to /series/1)
This also give us a couple benefits:
xpath will gone
we'll get a little speed improvements
Also our code will test collection page instead of a series page, that is more logical for a test of collection :)
php-coder
changed the title
StepDefinitions.seriesAddedToCollection():
StepDefinitions.seriesAddedToCollection(): modify logic
Sep 26, 2017
php-coder
changed the title
StepDefinitions.seriesAddedToCollection(): modify logic
StepDefinitions.seriesAddedToCollection(): modify test logic
Sep 26, 2017
I suggest to improve the following method:
mystamps/src/test/java/ru/mystamps/web/tests/StepDefinitions.java
Lines 69 to 75 in f72c87d
Instead of what it is doing now, it should:
Series has been added to your collection
is presented on the current page (hint: find an element with this message by a class name)href
attribute (is should equal to/series/1
)This also give us a couple benefits:
Also our code will test collection page instead of a series page, that is more logical for a test of collection :)
Tech debt for f72c87d (#46)
The text was updated successfully, but these errors were encountered: