Merge pull request #427 from arjanvdbos/stomp-ssl-support

Allow to enable SSL in StompConnectionFactory

Author: makasim

docs/bundle/config_reference.md

@@ -21,6 +21,9 @@ enqueue:
             connection_timeout:   1
             buffer_size:          1000
             lazy:                 true
+            
+            # Should be true if you want to use secure connections. False by default
+            ssl_on:               false
         rabbitmq_stomp:
             host:                 localhost
             port:                 61613

pkg/stomp/StompConnectionFactory.php

@@ -28,6 +28,7 @@ class StompConnectionFactory implements PsrConnectionFactory
      * 'connection_timeout' => 1,
      * 'sync' => false,
      * 'lazy' => true,
+     * 'ssl_on' => false,
      * ].
      *
      * or
@@ -75,7 +76,8 @@ private function establishConnection()
         if (false == $this->stomp) {
             $config = $this->config;
 
-            $uri = 'tcp://'.$config['host'].':'.$config['port'];
+            $scheme = (true === $config['ssl_on']) ? 'ssl' : 'tcp';
+            $uri = $scheme.'://'.$config['host'].':'.$config['port'];
             $connection = new Connection($uri, $config['connection_timeout']);
 
             $this->stomp = new BufferedStompClient($connection, $config['buffer_size']);
@@ -134,6 +136,7 @@ private function defaultConfig()
             'connection_timeout' => 1,
             'sync' => false,
             'lazy' => true,
+            'ssl_on' => false,
         ];
     }
 }

pkg/stomp/Symfony/StompTransportFactory.php

@@ -43,6 +43,7 @@ public function addConfiguration(ArrayNodeDefinition $builder)
                 ->integerNode('connection_timeout')->min(1)->defaultValue(1)->end()
                 ->integerNode('buffer_size')->min(1)->defaultValue(1000)->end()
                 ->booleanNode('lazy')->defaultTrue()->end()
+                ->booleanNode('ssl_on')->defaultFalse()->end()
         ;
     }
 

pkg/stomp/Tests/StompConnectionFactoryConfigTest.php

@@ -64,6 +64,7 @@ public static function provideConfigs()
                 'connection_timeout' => 1,
                 'sync' => false,
                 'lazy' => true,
+                'ssl_on' => false,
             ],
         ];
 
@@ -79,6 +80,7 @@ public static function provideConfigs()
                 'connection_timeout' => 1,
                 'sync' => false,
                 'lazy' => true,
+                'ssl_on' => false,
             ],
         ];
 
@@ -94,6 +96,7 @@ public static function provideConfigs()
                 'connection_timeout' => 1,
                 'sync' => false,
                 'lazy' => true,
+                'ssl_on' => false,
             ],
         ];
 
@@ -110,6 +113,7 @@ public static function provideConfigs()
                 'sync' => true,
                 'lazy' => false,
                 'foo' => 'bar',
+                'ssl_on' => false,
             ],
         ];
 
@@ -126,6 +130,7 @@ public static function provideConfigs()
                 'sync' => false,
                 'lazy' => true,
                 'foo' => 'bar',
+                'ssl_on' => false,
             ],
         ];
     }

pkg/stomp/Tests/Symfony/RabbitMqStompTransportFactoryTest.php

@@ -59,6 +59,7 @@ public function testShouldAllowAddConfiguration()
             'management_plugin_installed' => false,
             'management_plugin_port' => 15672,
             'lazy' => true,
+            'ssl_on' => false,
         ], $config);
     }
 

pkg/stomp/Tests/Symfony/StompTransportFactoryTest.php

@@ -55,6 +55,7 @@ public function testShouldAllowAddConfiguration()
             'connection_timeout' => 1,
             'buffer_size' => 1000,
             'lazy' => true,
+            'ssl_on' => false,
         ], $config);
     }