Skip to content

[DbalConsumer] Issue with id type #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
olix21 opened this issue Feb 8, 2018 · 4 comments
Closed

[DbalConsumer] Issue with id type #360

olix21 opened this issue Feb 8, 2018 · 4 comments

Comments

@olix21
Copy link
Contributor

olix21 commented Feb 8, 2018

Hi,

Trying to use a dbal connector from enqueue, we are facing some issues.

Migrating the id field definition from int to guid (php-enqueue/dbal@2566391#diff-2a7e2cb4e82b05f236840421016f498cR178) is great, but breaks this: https://github.com/php-enqueue/dbal/blob/master/DbalConsumer.php#L158

'id' => Type::INTEGER

should become

'id' => Type::GUID
@makasim
Copy link
Member

makasim commented Feb 8, 2018

Thanks for reporting. Could you work on PR that fixes it?

@makasim
Copy link
Member

makasim commented Feb 8, 2018

What database are you using?

@olix21
Copy link
Contributor Author

olix21 commented Feb 8, 2018

Sure I can do a PR.

I'm using Mysql 5.6.34

@olix21 olix21 mentioned this issue Feb 8, 2018
Merged
@olix21
Copy link
Contributor Author

olix21 commented Feb 8, 2018

Done: #361

@makasim makasim closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@makasim @olix21