Skip to content

[sqs] Support using a pre-configured SqsClient #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elazar opened this issue May 11, 2018 · 1 comment
Closed

[sqs] Support using a pre-configured SqsClient #443

elazar opened this issue May 11, 2018 · 1 comment

Comments

@elazar
Copy link
Contributor

elazar commented May 11, 2018

Currently, SqsConnectionFactory handles instantiating SqsClient and limits what settings are allowed.

For example, it doesn't presently support the http_handler setting, which is useful for logging the Guzzle requests and responses comprising communication between Enqueue and SQS.

I suspect that the easiest way to support more complex configurations would be to support having SqsConnectionFactory accept a pre-configured SqsClient instance for its $config parameter.

It looks like it may be possible to add this support using a custom connection factory implementation, but it would be nice to see it natively supported in the core SQS driver.

@makasim
Copy link
Member

makasim commented May 12, 2018

That would be great. By the way, it is something we did for redis transport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants