Skip to content

Deprecation notices #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chalasr opened this issue Dec 1, 2018 · 8 comments · Fixed by #688
Closed

Deprecation notices #667

chalasr opened this issue Dec 1, 2018 · 8 comments · Fixed by #688
Labels

Comments

@chalasr
Copy link

chalasr commented Dec 1, 2018

While upgrading to Symfony 4.2, I have the following unexpected deprecation notices:

The "Enqueue\Null\NullConnectionFactory" class implements "Interop\Queue\PsrConnectionFactory" that is deprecated will be removed in later versions. use one without Psr prefix.
--
The "Enqueue\Redis\RedisConnectionFactory" class implements "Interop\Queue\PsrConnectionFactory" that is deprecated will be removed in later versions. use one without Psr prefix.
--
The "Enqueue\Consumption\QueueConsumer::bindCallback()" method will require a new "string|InteropQueue $queueName" argument in the next major version of its parent class "Enqueue\Consumption\QueueConsumerInterface"
--
The "Enqueue\Client\RouterProcessor" class implements "Interop\Queue\PsrProcessor" that is deprecated will be removed in later versions. use one without Psr prefix.
--
The "Enqueue\Client\DelegateProcessor" class implements "Interop\Queue\PsrProcessor" that is deprecated will be removed in later versions. use one without Psr prefix.

It looks like some enqueue packages rely on deprecated features/classes of other enqueue packages, nothing I can fix on my side.
I'll give it a try, please stop me if you see a wontfix in the list.

@PaulRouss3l
Copy link

PaulRouss3l commented Dec 3, 2018

You can add the 0.7.1 version of queue-interop/queue-interop to your composer.json to avoid this issue for now

EDIT : changed version to a stable, thanks @makasim :)

@makasim
Copy link
Member

makasim commented Dec 3, 2018

fyi there is a stable 0.7 version of queue-interop

@chalasr
Copy link
Author

chalasr commented Dec 9, 2018

Well, I don't require queue-interop/queue-interop explicitly and the version I have is 0.7.1. Here are my requirements:

enqueue/enqueue-bundle  v0.9.1
enqueue/messenger-adapter v0.2.0
enqueue/redis  v0.9.1

And I get the deprecation notices mentioned above.
I still think this is not a dependency issue on my side but a bug in enqueue (broken BC layers).

@chalasr
Copy link
Author

chalasr commented Dec 9, 2018

The deprecated interfaces still exist in enqueue-interop v0.7.1, hence the notices. We probably need a new release.

@makasim
Copy link
Member

makasim commented Dec 10, 2018

Unfortunately, the deprecation notices are in 0.7 branch. There is no way to avoid it.

I am going to release queue interop 0.8 version which would be completely compatible with 0.7 releases except old interfaces are removed.

@chalasr
Copy link
Author

chalasr commented Dec 10, 2018

Fine for me, please close this issue once it is released.

@chalasr
Copy link
Author

chalasr commented Dec 13, 2018

Thanks @makasim

@makasim
Copy link
Member

makasim commented Dec 13, 2018

To get rid of the deprecated interface make sure you composer req queue-interop/queue-interop:^0.8

@makasim makasim reopened this Dec 13, 2018
@makasim makasim closed this as completed Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants