Running php-cs-fixer

Running php-cs-fixer to fix CS drift

Author: JimTools

CalculateRootJobStatusProcessor.php

@@ -38,7 +38,7 @@ public function __construct(
         JobStorage $jobStorage,
         CalculateRootJobStatusService $calculateRootJobStatusCase,
         ProducerInterface $producer,
-        LoggerInterface $logger
+        LoggerInterface $logger,
     ) {
         $this->jobStorage = $jobStorage;
         $this->calculateRootJobStatusService = $calculateRootJobStatusCase;

Commands.php

@@ -4,5 +4,5 @@
 
 class Commands
 {
-    const CALCULATE_ROOT_JOB_STATUS = 'enqueue.message_queue.job.calculate_root_job_status';
+    public const CALCULATE_ROOT_JOB_STATUS = 'enqueue.message_queue.job.calculate_root_job_status';
 }

DependentJobProcessor.php

@@ -37,9 +37,6 @@ public function __construct(JobStorage $jobStorage, ProducerInterface $producer,
         $this->logger = $logger;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function process(Message $message, Context $context)
     {
         $data = JSON::decode($message->getBody());

Doctrine/JobStorage.php

@@ -124,11 +124,11 @@ public function createJob()
     /**
      * @throws DuplicateJobException
      */
-    public function saveJob(Job $job, \Closure $lockCallback = null)
+    public function saveJob(Job $job, ?\Closure $lockCallback = null)
     {
         $class = $this->getEntityRepository()->getClassName();
         if (!$job instanceof $class) {
-            throw new \LogicException(sprintf('Got unexpected job instance: expected: "%s", actual" "%s"', $class, get_class($job)));
+            throw new \LogicException(sprintf('Got unexpected job instance: expected: "%s", actual" "%s"', $class, $job::class));
         }
 
         if ($lockCallback) {

Job.php

@@ -4,11 +4,11 @@
 
 class Job
 {
-    const STATUS_NEW = 'enqueue.job_queue.status.new';
-    const STATUS_RUNNING = 'enqueue.job_queue.status.running';
-    const STATUS_SUCCESS = 'enqueue.job_queue.status.success';
-    const STATUS_FAILED = 'enqueue.job_queue.status.failed';
-    const STATUS_CANCELLED = 'enqueue.job_queue.status.cancelled';
+    public const STATUS_NEW = 'enqueue.job_queue.status.new';
+    public const STATUS_RUNNING = 'enqueue.job_queue.status.running';
+    public const STATUS_SUCCESS = 'enqueue.job_queue.status.success';
+    public const STATUS_FAILED = 'enqueue.job_queue.status.failed';
+    public const STATUS_CANCELLED = 'enqueue.job_queue.status.cancelled';
 
     /**
      * @var int
@@ -216,8 +216,6 @@ public function getRootJob()
      * Do not call from the outside.
      *
      * @internal
-     *
-     * @param Job $rootJob
      */
     public function setRootJob(self $rootJob)
     {

JobRunner.php

@@ -14,10 +14,7 @@ class JobRunner
      */
     private $rootJob;
 
-    /**
-     * @param Job $rootJob
-     */
-    public function __construct(JobProcessor $jobProcessor, Job $rootJob = null)
+    public function __construct(JobProcessor $jobProcessor, ?Job $rootJob = null)
     {
         $this->jobProcessor = $jobProcessor;
         $this->rootJob = $rootJob;
@@ -28,8 +25,6 @@ public function __construct(JobProcessor $jobProcessor, Job $rootJob = null)
      * @param string $name
      *
      * @throws \Throwable|\Exception if $runCallback triggers an exception
-     *
-     * @return mixed
      */
     public function runUnique($ownerId, $name, callable $runCallback)
     {
@@ -69,8 +64,6 @@ public function runUnique($ownerId, $name, callable $runCallback)
 
     /**
      * @param string $name
-     *
-     * @return mixed
      */
     public function createDelayed($name, callable $startCallback)
     {
@@ -83,8 +76,6 @@ public function createDelayed($name, callable $startCallback)
 
     /**
      * @param string $jobId
-     *
-     * @return mixed
      */
     public function runDelayed($jobId, callable $runCallback)
     {

Test/DbalPersistedConnection.php

@@ -22,9 +22,6 @@ class DbalPersistedConnection extends Connection
      */
     protected static $persistedTransactionNestingLevels;
 
-    /**
-     * {@inheritdoc}
-     */
     public function connect()
     {
         if ($this->isConnected()) {
@@ -41,25 +38,16 @@ public function connect()
         return true;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function beginTransaction()
     {
         $this->wrapTransactionNestingLevel('beginTransaction');
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function commit()
     {
         $this->wrapTransactionNestingLevel('commit');
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function rollBack()
     {
         $this->wrapTransactionNestingLevel('rollBack');

Test/JobRunner.php

@@ -26,33 +26,20 @@ public function __construct()
     {
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function runUnique($ownerId, $jobName, \Closure $runCallback)
     {
         $this->runUniqueJobs[] = ['ownerId' => $ownerId, 'jobName' => $jobName, 'runCallback' => $runCallback];
 
         return call_user_func($runCallback, $this, new Job());
     }
 
-    /**
-     * {@inheritdoc}
-     *
-     * @return mixed
-     */
     public function createDelayed($jobName, \Closure $startCallback)
     {
         $this->createDelayedJobs[] = ['jobName' => $jobName, 'runCallback' => $startCallback];
 
         return call_user_func($startCallback, $this, new Job());
     }
 
-    /**
-     * {@inheritdoc}
-     *
-     * @return mixed
-     */
     public function runDelayed($jobId, \Closure $runCallback)
     {
         $this->runDelayedJobs[] = ['jobId' => $jobId, 'runCallback' => $runCallback];

Tests/CalculateRootJobStatusServiceTest.php

@@ -20,8 +20,6 @@ public function stopStatusProvider()
 
     /**
      * @dataProvider stopStatusProvider
-     *
-     * @param mixed $status
      */
     public function testShouldDoNothingIfRootJobHasStopState($status)
     {
@@ -70,8 +68,6 @@ public function testShouldCalculateRootJobStatus()
 
     /**
      * @dataProvider stopStatusProvider
-     *
-     * @param mixed $stopStatus
      */
     public function testShouldCalculateRootJobStatusAndSetStoppedAtTimeIfGotStopStatus($stopStatus)
     {
@@ -356,7 +352,7 @@ public function testShouldSetStatusSuccessIfAllAreSuccess()
     }
 
     /**
-     * @return MockObject|\Enqueue\JobQueue\Doctrine\JobStorage
+     * @return MockObject|JobStorage
      */
     private function createJobStorageMock()
     {

Tests/DependentJobProcessorTest.php

@@ -326,7 +326,7 @@ private function createContextMock()
     }
 
     /**
-     * @return MockObject|\Enqueue\JobQueue\Doctrine\JobStorage
+     * @return MockObject|JobStorage
      */
     private function createJobStorageMock()
     {