Skip to content

Be compatible with php 5.4 #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kpn13 opened this issue Aug 8, 2017 · 2 comments
Closed

Be compatible with php 5.4 #99

kpn13 opened this issue Aug 8, 2017 · 2 comments

Comments

@kpn13
Copy link

kpn13 commented Aug 8, 2017

Q A
Bug? no
New Feature? no

Hi,

If I'm right, this lib is not compatible with PHP 5.4 just because of "::class" used in tests. Are you against a PR which will replace "::class" by the fully qualified class name ?

Best regards.
@kpn13
Copy link
Author

kpn13 commented Aug 8, 2017

Sorry I just saw #61 so I imagine be compatible with 5.4 is not an option anymore.

@kpn13 kpn13 closed this as completed Aug 8, 2017
@Nyholm
Copy link
Member

Nyholm commented Aug 8, 2017 •
edited
Loading

Thank you for this issue. I see no reason to do work to support legacy versions of PHP.

As soon as there is a PR with a decent reason to drop PHP 5.6 I would be happy to merge it =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kpn13 @Nyholm