Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation on RetryPlugin #232

Open
Nyholm opened this issue Apr 21, 2018 · 2 comments
Open

Update documentation on RetryPlugin #232

Nyholm opened this issue Apr 21, 2018 · 2 comments

Comments

@Nyholm
Copy link
Member

Nyholm commented Apr 21, 2018

The plugin has some new parameters that should be documented.
@kozlice
Copy link

kozlice commented May 20, 2018

It's also confusing that parameter retry is called retries in docs. I had to check the actual configurator's source code to find out why it wasn't working. The comment there says // TODO: should be called retries for consistency with the class :)

@dbu
Copy link
Contributor

dbu commented May 23, 2018

uh. then we should probably support both, but report a deprecation warning when using retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbu @kozlice @Nyholm